Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return and saved results as detections crops using results.crop(save=True) #11933

Closed
2 tasks done
hulkds opened this issue Aug 2, 2023 · 7 comments
Closed
2 tasks done
Labels
bug Something isn't working fixed Bug has been resolved Stale

Comments

@hulkds
Copy link

hulkds commented Aug 2, 2023

Search before asking

  • I have searched the YOLOv5 issues and found no similar bug report.

YOLOv5 Component

Detection

Bug

Bug when doing results.crop(save=True) after load yolov5 via pytorch hub.

Bug message:

# b = xyxy2xywh(xyxy.view(-1, 4))  # boxes
AttributeError: 'list' object has no attribute 'view'

Bug found in this line

Solution:

b = xyxy2xywh(torch.stack(xyxy).view(-1, 4))  # boxes

Environment

  • YOLOv5 🚀 2023-8-2 Python-3.10.12 torch-2.0.1+cu117 CUDA:0 (NVIDIA GeForce GTX 1650 Ti, 3904MiB)
  • Ubuntu 22.04
  • Python3.10.12

Minimal Reproducible Example

import torch

# Model
model = torch.hub.load('ultralytics/yolov5', 'yolov5s')

# Image
im = 'https://ultralytics.com/images/zidane.jpg'

# Inference
results = model(im)

# cropped detections dictionary
crops = results.crop(save=True)  

Additional

Consider using BGR=True if the crops colors is not what you want.

crops = results.crop(save=True, BGR=True) 

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@hulkds hulkds added the bug Something isn't working label Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

👋 Hello @hulkds, thank you for your interest in YOLOv5 🚀! Please visit our ⭐️ Tutorials to get started, where you can find quickstart guides for simple tasks like Custom Data Training all the way to advanced concepts like Hyperparameter Evolution.

If this is a 🐛 Bug Report, please provide a minimum reproducible example to help us debug it.

If this is a custom training ❓ Question, please provide as much information as possible, including dataset image examples and training logs, and verify you are following our Tips for Best Training Results.

Requirements

Python>=3.7.0 with all requirements.txt installed including PyTorch>=1.7. To get started:

git clone https://github.com/ultralytics/yolov5  # clone
cd yolov5
pip install -r requirements.txt  # install

Environments

YOLOv5 may be run in any of the following up-to-date verified environments (with all dependencies including CUDA/CUDNN, Python and PyTorch preinstalled):

Status

YOLOv5 CI

If this badge is green, all YOLOv5 GitHub Actions Continuous Integration (CI) tests are currently passing. CI tests verify correct operation of YOLOv5 training, validation, inference, export and benchmarks on macOS, Windows, and Ubuntu every 24 hours and on every commit.

Introducing YOLOv8 🚀

We're excited to announce the launch of our latest state-of-the-art (SOTA) object detection model for 2023 - YOLOv8 🚀!

Designed to be fast, accurate, and easy to use, YOLOv8 is an ideal choice for a wide range of object detection, image segmentation and image classification tasks. With YOLOv8, you'll be able to quickly and accurately detect objects in real-time, streamline your workflows, and achieve new levels of accuracy in your projects.

Check out our YOLOv8 Docs for details and get started with:

pip install ultralytics

@glenn-jocher
Copy link
Member

@hulkds this is a known bug when using results.crop(save=True) after loading YOLOv5 via PyTorch Hub. The error is caused by a line in the code that expects a tensor but receives a list.

To address this issue, you can modify the code at line 296 in ultralytics/utils/plotting.py as follows:

b = xyxy2xywh(torch.stack(xyxy).view(-1, 4))  # boxes

This change will convert the list of bounding boxes into a tensor before passing it to the xyxy2xywh function.

Thank you for bringing this to our attention, and we appreciate your willingness to submit a PR! Your contribution is valuable to the YOLOv5 community.

@hulkds
Copy link
Author

hulkds commented Aug 2, 2023

@glenn-jocher I faced a CI error:
E TypeError: stack(): argument 'tensors' (position 1) must be tuple of Tensors, not Tensor

To address this issue, I tried to pass a tuple in torch.stack() and it works

b = xyxy2xywh(torch.stack((xyxy)).view(-1, 4))  # boxes

I'll rerun the Ultralytics CI workfow and will submit the PR again.

@hulkds
Copy link
Author

hulkds commented Aug 2, 2023

@glenn-jocher I have created a PR: ultralytics/ultralytics#4124

@glenn-jocher
Copy link
Member

@hulkds thank you for creating the pull request! We appreciate your contribution to the YOLOv5 repository. Our team will review it and provide feedback as soon as possible. Keep up the good work!

@glenn-jocher
Copy link
Member

@hulkds ok between ultralytics/ultralytics#4127 and #11936 I think this bug should be resolved.

Please update YOLOv5 dependencies with pip install -r requirements.txt and try again, thank you!

@glenn-jocher glenn-jocher added the fixed Bug has been resolved label Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

👋 Hello there! We wanted to give you a friendly reminder that this issue has not had any recent activity and may be closed soon, but don't worry - you can always reopen it if needed. If you still have any questions or concerns, please feel free to let us know how we can help.

For additional resources and information, please see the links below:

Feel free to inform us of any other issues you discover or feature requests that come to mind in the future. Pull Requests (PRs) are also always welcomed!

Thank you for your contributions to YOLO 🚀 and Vision AI ⭐

@github-actions github-actions bot added the Stale label Sep 2, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Bug has been resolved Stale
Projects
None yet
Development

No branches or pull requests

2 participants