Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classify/predict.py should have an option to save results as CSV #11482

Closed
2 tasks done
sohang3112 opened this issue May 4, 2023 · 38 comments
Closed
2 tasks done

classify/predict.py should have an option to save results as CSV #11482

sohang3112 opened this issue May 4, 2023 · 38 comments
Labels
enhancement New feature or request

Comments

@sohang3112
Copy link

sohang3112 commented May 4, 2023

Search before asking

  • I have searched the YOLOv5 issues and found no similar feature requests.

Description

The script classify/predict.py prints its results to the console, but doesn't save the results anywhere. It would be nice if the results were also saved as a CSV somewhere for easy analysis.

PS: Currently I analyze the results by copying output of classify/predict.py and converting to CSV using AWK (see my Github Gist). But this solution is not ideal.

Use case

This will be useful for testing and comparing performance of different models on testing data.

Additional

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@sohang3112 sohang3112 added the enhancement New feature or request label May 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

👋 Hello @sohang3112, thank you for your interest in YOLOv5 🚀! Please visit our ⭐️ Tutorials to get started, where you can find quickstart guides for simple tasks like Custom Data Training all the way to advanced concepts like Hyperparameter Evolution.

If this is a 🐛 Bug Report, please provide a minimum reproducible example to help us debug it.

If this is a custom training ❓ Question, please provide as much information as possible, including dataset image examples and training logs, and verify you are following our Tips for Best Training Results.

Requirements

Python>=3.7.0 with all requirements.txt installed including PyTorch>=1.7. To get started:

git clone https://github.com/ultralytics/yolov5  # clone
cd yolov5
pip install -r requirements.txt  # install

Environments

YOLOv5 may be run in any of the following up-to-date verified environments (with all dependencies including CUDA/CUDNN, Python and PyTorch preinstalled):

Status

YOLOv5 CI

If this badge is green, all YOLOv5 GitHub Actions Continuous Integration (CI) tests are currently passing. CI tests verify correct operation of YOLOv5 training, validation, inference, export and benchmarks on macOS, Windows, and Ubuntu every 24 hours and on every commit.

Introducing YOLOv8 🚀

We're excited to announce the launch of our latest state-of-the-art (SOTA) object detection model for 2023 - YOLOv8 🚀!

Designed to be fast, accurate, and easy to use, YOLOv8 is an ideal choice for a wide range of object detection, image segmentation and image classification tasks. With YOLOv8, you'll be able to quickly and accurately detect objects in real-time, streamline your workflows, and achieve new levels of accuracy in your projects.

Check out our YOLOv8 Docs for details and get started with:

pip install ultralytics

@glenn-jocher
Copy link
Member

@sohang3112 hello, thank you for your interest in contributing to YOLOv5!

We appreciate your feedback on enhancing classify/predict.py to save results as a CSV for easy analysis. It's great to see that you are considering the usefulness of this feature for testing and comparing performance of different models on testing data.

We welcome all PRs and are looking forward to seeing your contribution to YOLOv5 on this issue. Please let us know if you have any questions or need any assistance during the process.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023

👋 Hello there! We wanted to give you a friendly reminder that this issue has not had any recent activity and may be closed soon, but don't worry - you can always reopen it if needed. If you still have any questions or concerns, please feel free to let us know how we can help.

For additional resources and information, please see the links below:

Feel free to inform us of any other issues you discover or feature requests that come to mind in the future. Pull Requests (PRs) are also always welcomed!

Thank you for your contributions to YOLO 🚀 and Vision AI ⭐

@sohang3112
Copy link
Author

@glenn-jocher I submitted this Pull Request to add this feature to classify/predict.py. Please review the PR.

@glenn-jocher
Copy link
Member

@sohang3112 thank you for submitting your Pull Request to add the requested feature to classify/predict.py. Our team appreciates your contribution to YOLOv5 🚀. We will review the PR and provide feedback if any changes are required. You can expect an update from us soon.

@github-actions github-actions bot removed the Stale label Jun 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

👋 Hello there! We wanted to give you a friendly reminder that this issue has not had any recent activity and may be closed soon, but don't worry - you can always reopen it if needed. If you still have any questions or concerns, please feel free to let us know how we can help.

For additional resources and information, please see the links below:

Feel free to inform us of any other issues you discover or feature requests that come to mind in the future. Pull Requests (PRs) are also always welcomed!

Thank you for your contributions to YOLO 🚀 and Vision AI ⭐

@github-actions github-actions bot added the Stale label Jul 5, 2023
@sohang3112
Copy link
Author

@glenn-jocher Did you have a chance to review my PR (linked above)? Just saw that the issue has been marked Stale again today.

@glenn-jocher
Copy link
Member

@sohang3112 Thank you for your contribution to YOLOv5 and for following up on your pull request. I apologize for the delay in reviewing your PR. Our team is currently working through a high volume of pull requests and we appreciate your patience.

We will make sure to review your PR as soon as possible and provide feedback. Thank you once again for your contribution and for your understanding.

@github-actions github-actions bot removed the Stale label Jul 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

👋 Hello there! We wanted to give you a friendly reminder that this issue has not had any recent activity and may be closed soon, but don't worry - you can always reopen it if needed. If you still have any questions or concerns, please feel free to let us know how we can help.

For additional resources and information, please see the links below:

Feel free to inform us of any other issues you discover or feature requests that come to mind in the future. Pull Requests (PRs) are also always welcomed!

Thank you for your contributions to YOLO 🚀 and Vision AI ⭐

@github-actions github-actions bot added the Stale label Aug 6, 2023
@sohang3112
Copy link
Author

@glenn-jocher If you had the chance to review my pull request (linked above), please comment about it here. Otherwise, GitHub Actions bot will close this issue (it has already marked this issue as Stale) 😔.

@glenn-jocher
Copy link
Member

@sohang3112 Thank you for your contribution and for patiently waiting for the review of your pull request. We apologize for the delay in providing feedback. Our team is currently working through a high volume of pull requests and your contribution is important to us.

We will make sure to review your pull request as soon as possible. We appreciate your understanding and thank you for your patience.

@github-actions github-actions bot removed the Stale label Aug 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

👋 Hello there! We wanted to give you a friendly reminder that this issue has not had any recent activity and may be closed soon, but don't worry - you can always reopen it if needed. If you still have any questions or concerns, please feel free to let us know how we can help.

For additional resources and information, please see the links below:

Feel free to inform us of any other issues you discover or feature requests that come to mind in the future. Pull Requests (PRs) are also always welcomed!

Thank you for your contributions to YOLO 🚀 and Vision AI ⭐

@github-actions github-actions bot added the Stale label Sep 7, 2023
@sohang3112
Copy link
Author

@glenn-jocher Did you have a chance to review my PR for this issue yet? Please comment to prevent github-actions bot from closing this issue.

@glenn-jocher
Copy link
Member

@sohang3112 thank you for your contribution and for following up on your pull request. Apologies for the delay in reviewing your PR. Our team is currently dealing with a high volume of pull requests and we appreciate your patience. We will make sure to review your PR as soon as possible. Thank you again for your contribution and understanding.

@github-actions github-actions bot removed the Stale label Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

👋 Hello there! We wanted to give you a friendly reminder that this issue has not had any recent activity and may be closed soon, but don't worry - you can always reopen it if needed. If you still have any questions or concerns, please feel free to let us know how we can help.

For additional resources and information, please see the links below:

Feel free to inform us of any other issues you discover or feature requests that come to mind in the future. Pull Requests (PRs) are also always welcomed!

Thank you for your contributions to YOLO 🚀 and Vision AI ⭐

@github-actions github-actions bot added the Stale label Oct 8, 2023
@sohang3112
Copy link
Author

@glenn-jocher Did you have a chance to review my PR yet?

@glenn-jocher
Copy link
Member

@sohang3112 Thank you for your patience. We apologize for the delay in reviewing your PR. Our team is currently working through a high volume of pull requests, but we assure you we will review your contribution as soon as possible. Thank you for your understanding and for your valuable contribution to YOLOv5.

@github-actions github-actions bot removed the Stale label Oct 9, 2023
Copy link
Contributor

github-actions bot commented Nov 9, 2023

👋 Hello there! We wanted to give you a friendly reminder that this issue has not had any recent activity and may be closed soon, but don't worry - you can always reopen it if needed. If you still have any questions or concerns, please feel free to let us know how we can help.

For additional resources and information, please see the links below:

Feel free to inform us of any other issues you discover or feature requests that come to mind in the future. Pull Requests (PRs) are also always welcomed!

Thank you for your contributions to YOLO 🚀 and Vision AI ⭐

@sohang3112
Copy link
Author

@glenn-jocher Did you have a chance to review my PR yet?

@glenn-jocher
Copy link
Member

@sohang3112 thank you for your patience. Our team is currently handling a high volume of pull requests and we will review your contribution as soon as possible. We appreciate your understanding and your valuable contribution to YOLOv5.

@github-actions github-actions bot removed the Stale label Nov 10, 2023
Copy link
Contributor

👋 Hello there! We wanted to give you a friendly reminder that this issue has not had any recent activity and may be closed soon, but don't worry - you can always reopen it if needed. If you still have any questions or concerns, please feel free to let us know how we can help.

For additional resources and information, please see the links below:

Feel free to inform us of any other issues you discover or feature requests that come to mind in the future. Pull Requests (PRs) are also always welcomed!

Thank you for your contributions to YOLO 🚀 and Vision AI ⭐

@github-actions github-actions bot added the Stale label Dec 10, 2023
@sohang3112
Copy link
Author

@glenn-jocher Please review the linked PR - it has been open for months now. GitHub Actions not also marked it Stale multiple times due to lack of activity / comments.

@glenn-jocher
Copy link
Member

@sohang3112 We apologize for the delay and thank you for your patience. We understand the importance of timely feedback and will prioritize the review of your PR to ensure its progress. Your contribution is valuable to us, and we appreciate your understanding as we work through our current workload. Thank you for your understanding and your commitment to YOLOv5.

@github-actions github-actions bot removed the Stale label Dec 11, 2023
Copy link
Contributor

👋 Hello there! We wanted to give you a friendly reminder that this issue has not had any recent activity and may be closed soon, but don't worry - you can always reopen it if needed. If you still have any questions or concerns, please feel free to let us know how we can help.

For additional resources and information, please see the links below:

Feel free to inform us of any other issues you discover or feature requests that come to mind in the future. Pull Requests (PRs) are also always welcomed!

Thank you for your contributions to YOLO 🚀 and Vision AI ⭐

@github-actions github-actions bot added the Stale label Jan 11, 2024
@sohang3112
Copy link
Author

@glenn-jocher Please review the linked PR - it has been open for a long time. It's a small PR (changes in one file only), so it should only take a few minutes.

@glenn-jocher
Copy link
Member

@sohang3112 I apologize for the inconvenience caused by the delay. I'll make sure to review your PR as soon as possible. We appreciate your contribution and your patience. Thank you for bringing this to my attention and for your understanding.

@github-actions github-actions bot removed the Stale label Jan 12, 2024
Copy link
Contributor

👋 Hello there! We wanted to give you a friendly reminder that this issue has not had any recent activity and may be closed soon, but don't worry - you can always reopen it if needed. If you still have any questions or concerns, please feel free to let us know how we can help.

For additional resources and information, please see the links below:

Feel free to inform us of any other issues you discover or feature requests that come to mind in the future. Pull Requests (PRs) are also always welcomed!

Thank you for your contributions to YOLO 🚀 and Vision AI ⭐

@github-actions github-actions bot added the Stale label Feb 11, 2024
@sohang3112
Copy link
Author

@glenn-jocher Were you able to review the linked PR yet?

@glenn-jocher
Copy link
Member

@sohang3112 I apologize for any further delay. I will ensure that your PR is reviewed promptly. Thank you for your continued patience and for your contribution to the YOLOv5 project. Your efforts are truly appreciated.

@github-actions github-actions bot removed the Stale label Feb 12, 2024
Copy link
Contributor

👋 Hello there! We wanted to give you a friendly reminder that this issue has not had any recent activity and may be closed soon, but don't worry - you can always reopen it if needed. If you still have any questions or concerns, please feel free to let us know how we can help.

For additional resources and information, please see the links below:

Feel free to inform us of any other issues you discover or feature requests that come to mind in the future. Pull Requests (PRs) are also always welcomed!

Thank you for your contributions to YOLO 🚀 and Vision AI ⭐

@github-actions github-actions bot added the Stale label Mar 14, 2024
@sohang3112
Copy link
Author

@glenn-jocher This PR has been open for a very long time now - if you don't intend to review it, just close the PR and be done with it.

@glenn-jocher
Copy link
Member

@sohang3112 I'm truly sorry for the delays and any frustration this has caused. It's not our intention to overlook your efforts. I'll prioritize reviewing your PR to provide feedback or take necessary action as soon as possible. Your contributions are valuable to us, and we appreciate your patience and understanding throughout this process. Thank you for your dedication to improving YOLOv5.

@github-actions github-actions bot removed the Stale label Mar 15, 2024
@Halafz7
Copy link

Halafz7 commented Mar 25, 2024

@glenn-jocher This PR has been open for a very long time now - if you don't intend to review it, just close the PR and be done with it.

Is it already done? I'm looking for it too

@sohang3112
Copy link
Author

@Halafz7 No the PR is still not merged because @glenn-jocher hasn't reviewed it.

@sohang3112
Copy link
Author

@glenn-jocher If you're so busy that you can't review the PR at all, then why don't you delegate to another maintainer?

And BTW the changes in the PR are small - only a few lines are added in a single Python file.

@glenn-jocher
Copy link
Member

@sohang3112 i'm genuinely sorry for the delay and appreciate your suggestion. We're a small team doing our best to manage a large volume of requests. I'll ensure your PR is flagged for immediate attention, either by myself or another team member. Your understanding and patience mean a lot to us, and thank you for your valuable contribution to YOLOv5.

@sohang3112
Copy link
Author

sohang3112 commented Apr 18, 2024

@glenn-jocher What sort of behaviour is this from your side?? Just today I got the message that Github Actions bot closed my linked PR for inactivity. The PR has been open for many months now, and throughout all that time you didn't find the time to even look at the changes once (let alone review & merge) ?? The only comments from you have been these useless bullshit platitudes of "valuable contribution". In the same time, you found the time to merge many other PRs in this repo, but you didn't even have the time to check the code change in my PR even once??

I have had enough - I'll make sure to never again contribute to any yolo project or any project maintained by you. Bye 👎

@glenn-jocher
Copy link
Member

I'm deeply sorry for the frustration and disappointment this situation has caused. It's never our intention to overlook the hard work and contributions of our community. We understand the effort you've put into your PR, and it's regrettable that we weren't able to review it in a timely manner. Your feedback is a valuable lesson for us to improve our review process and ensure more timely and constructive engagement with contributors moving forward. Thank you for your past contributions, and I truly apologize for any disillusionment this experience has caused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants