Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessing image using ONNX model gives warning each time inference is run #11473

Closed
1 of 2 tasks
MathijsNL opened this issue May 2, 2023 · 5 comments
Closed
1 of 2 tasks
Labels
bug Something isn't working Stale

Comments

@MathijsNL
Copy link

Search before asking

  • I have searched the YOLOv5 issues and found no similar bug report.

YOLOv5 Component

Detection, Export

Bug

As far as I understand the check self.model.pt will always be False if ONNX is used. Getting this warning for each detection is annoying. I think giving this warning once when it occurs and then skip it afterwards is the way to go.

https://github.com/ultralytics/ultralytics/blob/44c7c3514d87a5e05cfb14dba5a3eeb6eb860e70/ultralytics/yolo/engine/predictor.py#L118-L121

    def preprocess(self, im):
        """Prepares input image before inference.
        Args:
            im (torch.Tensor | List(np.ndarray)): (N, 3, h, w) for tensor, [(h, w, 3) x N] for list.
        """
        if not isinstance(im, torch.Tensor):
            auto = all(x.shape == im[0].shape for x in im) and self.model.pt
            if not auto:
                LOGGER.warning(
                    'WARNING ⚠️ Source shapes differ. For optimal performance supply similarly-shaped sources.')

Environment

Ultralytics YOLOv8.0.91 🚀 Python-3.10.10 torch-1.13.1+cpu CPU
Using WSL2 Ubuntu 22.04

Minimal Reproducible Example

You need an ONNX exported model for this (I think OPSET 12)

from ultralytics import YOLO
model = YOLO('yolo.onnx', task='detect')
results = model('../images/2023-04-25_15_10_16_144.jpg', verbose=False, mode='predict')

Additional

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@MathijsNL MathijsNL added the bug Something isn't working label May 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

👋 Hello @MathijsNL, thank you for your interest in YOLOv5 🚀! Please visit our ⭐️ Tutorials to get started, where you can find quickstart guides for simple tasks like Custom Data Training all the way to advanced concepts like Hyperparameter Evolution.

If this is a 🐛 Bug Report, please provide a minimum reproducible example to help us debug it.

If this is a custom training ❓ Question, please provide as much information as possible, including dataset image examples and training logs, and verify you are following our Tips for Best Training Results.

Requirements

Python>=3.7.0 with all requirements.txt installed including PyTorch>=1.7. To get started:

git clone https://github.com/ultralytics/yolov5  # clone
cd yolov5
pip install -r requirements.txt  # install

Environments

YOLOv5 may be run in any of the following up-to-date verified environments (with all dependencies including CUDA/CUDNN, Python and PyTorch preinstalled):

Status

YOLOv5 CI

If this badge is green, all YOLOv5 GitHub Actions Continuous Integration (CI) tests are currently passing. CI tests verify correct operation of YOLOv5 training, validation, inference, export and benchmarks on macOS, Windows, and Ubuntu every 24 hours and on every commit.

Introducing YOLOv8 🚀

We're excited to announce the launch of our latest state-of-the-art (SOTA) object detection model for 2023 - YOLOv8 🚀!

Designed to be fast, accurate, and easy to use, YOLOv8 is an ideal choice for a wide range of object detection, image segmentation and image classification tasks. With YOLOv8, you'll be able to quickly and accurately detect objects in real-time, streamline your workflows, and achieve new levels of accuracy in your projects.

Check out our YOLOv8 Docs for details and get started with:

pip install ultralytics

@glenn-jocher
Copy link
Member

Hello @MathijsNL,

Thank you for bringing this issue to our attention. We apologize for any inconvenience that this warning may be causing you.

Regarding the behavior of the self.model.pt check, you are correct that it will always be False when using an ONNX model. We appreciate your suggestion to give this warning once when it occurs and then skip it afterwards.

We will review your suggestion and consider it for inclusion in a future update to YOLOv5.

Thank you for your interest in YOLOv5 and for your contribution to the project!

@MathijsNL
Copy link
Author

Thanks for your response @glenn-jocher

In the meantime if anyone comes across this issue there is a relatively simple workaround:

import logging
from ultralytics import YOLO

yolologger = logging.getLogger('ultralytics')
yolologger.setLevel(logging.CRITICAL)

And a suggestion for the warn once:

self.not_auto_warned = False
            if not auto and self.not_auto_warned:
                LOGGER.warning(...
                self.not_auto_warned = True

Also I noticed that I made the issue under the wrong repo -_- Should have been under the ultralytics repository.
Do you want me to create an issue there so it doesn't get mixed up with the issues here?

@glenn-jocher
Copy link
Member

Hi @MathijsNL,

Thank you for providing a workaround for the warning issue. Your suggestion for the warn once feature is also appreciated, we will review it for inclusion in a future update.

Regarding the issue being created under the wrong repo, it's not a problem. We will transfer it to the ultralytics repository for better tracking and handling. Thank you for considering it.

Please let us know if you have any more questions or concerns, we're here to help.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

👋 Hello there! We wanted to give you a friendly reminder that this issue has not had any recent activity and may be closed soon, but don't worry - you can always reopen it if needed. If you still have any questions or concerns, please feel free to let us know how we can help.

For additional resources and information, please see the links below:

Feel free to inform us of any other issues you discover or feature requests that come to mind in the future. Pull Requests (PRs) are also always welcomed!

Thank you for your contributions to YOLO 🚀 and Vision AI ⭐

@github-actions github-actions bot added the Stale label Jun 2, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

No branches or pull requests

2 participants