Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A problem in test.py? #227

Closed
Peterisfar opened this issue Apr 20, 2019 · 2 comments
Closed

A problem in test.py? #227

Peterisfar opened this issue Apr 20, 2019 · 2 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@Peterisfar
Copy link

line in 125 : iou, bi = bbox_iou(pbox, tbox).max(0)

Why do you take the largest index value that overlaps an anchor with the GTs IOU? For example, when two objects are close together, if the two objects are IOU 0.98 and 0.93 respectively, but the categories of the two are different, 0.93 is correct. If the index is the largest, the correct answer is discarded.so i think it's not robust!

@Peterisfar Peterisfar added the enhancement New feature or request label Apr 20, 2019
@glenn-jocher glenn-jocher added the duplicate This issue or pull request already exists label Apr 21, 2019
@glenn-jocher
Copy link
Member

@Peterisfar thanks for the comment. Yes you are right there is something incorrect in the test.py mAP computation. We left it this way because changing this causes the reported mAP to deviate further from the pycocotools mAP using python3 test.py --save-json.

Closing as duplicate of #222

@glenn-jocher
Copy link
Member

@Peterisfar this should be fixed now in commit e1850bf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants