Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct key names to match server #72

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

kalenmike
Copy link
Contributor

@kalenmike kalenmike commented Jan 9, 2024

This PR corrects the key names for the response returned by the server.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced model property checks in the hub-sdk.

πŸ“Š Key Changes

  • Changed the is_resumable method to check for has_last_weights instead of checking the status for "training".
  • Updated the has_best_weights method to directly check a new flag has_best_weights rather than deriving from other properties.
  • Standardized boolean property names in is_pretrained and is_custom methods to is_pretrained and is_custom for consistency.

🎯 Purpose & Impact

  • πŸ› οΈ Improved Consistency: Property names and checks are now more consistent and self-descriptive, reducing confusion.
  • ⏩ Efficient Checks: Direct property checks may improve efficiency when querying model states.
  • πŸ§‘β€πŸ’» Better Developer Experience: Clearer property names can help developers understand the SDK capabilities faster.
  • πŸ“ˆ Potential for More Accurate Model State Reporting: By using more explicit flags, models' states might be represented more accurately in the hub.

@kalenmike kalenmike merged commit dc95c97 into develop Jan 9, 2024
3 checks passed
@kalenmike kalenmike deleted the fix/update-to-work-with-server-response branch January 9, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant