Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Model methods #71

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Update Model methods #71

merged 1 commit into from
Jan 9, 2024

Conversation

hassaanfarooq01
Copy link
Contributor

@hassaanfarooq01 hassaanfarooq01 commented Jan 9, 2024

  • Update Model methods accordingly server model retrieve endpoint

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhanced model status checks and streamlined URL retrieval processes in Ultralytics Hub SDK.

📊 Key Changes

  • Replaced hasLastWeights with status == "training" for resumability check.
  • Updated has_best_weights check to depend on training status and weights presence.
  • Swapped isTrained with status == "trained" to determine training status.
  • Replaced architecture retrieval from a nested lineage object with direct cfg attribute access.
  • Simplified dataset URL retrieval by utilizing direct data access instead of an HTTP request.
  • Streamlined weight URL retrieval logic with direct attribute access, handling weight == "last" separately.

🎯 Purpose & Impact

  • Improved Clarity: Changing status checks aligns model property methods with clearer, centralized status values.
  • Faster Performance: Direct attribute access for configuration and URLs reduces the need for HTTP requests, speeding up operations.
  • Simpler Codebase: The code is simplified, making it easier to maintain and less prone to errors.
  • Enhanced User Experience: These changes lead to quicker responses and more intuitive interactions for SDK users, facilitating smoother model management within Ultralytics' ecosystem.

@kalenmike kalenmike merged commit 98f2cca into develop Jan 9, 2024
3 checks passed
@kalenmike kalenmike deleted the feat/update_model_methods branch January 9, 2024 12:54
kalenmike added a commit that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants