Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Conda Package #104

Closed
wants to merge 1 commit into from

Conversation

hassaanfarooq01
Copy link
Contributor

@hassaanfarooq01 hassaanfarooq01 commented Feb 22, 2024

  • Build the package using gryskull
  • It uses hosted pypip packacge and configure it for Conda
  • Here is the Doc follow to build and upload the Package

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Introducing a Conda package for the Ultralytics HUB SDK, version 0.0.4 🎉

📊 Key Changes

  • New Conda recipe added: Makes installing the HUB SDK with Conda possible.
  • Package details specified: Including name, version, source url, and sha256 checksum for validation.
  • Build and Installation Instructions: Setup for Python noarch (architecture agnostic), requiring Python >= 3.8 and other essential tools for installation (setuptools, wheel, pip).
  • Dependencies defined: Requirements for both host setup and run environment, such as Python >= 3.8 and requests library.
  • Testing suite: Includes basic import tests and pip check.
  • Metadata enrichment: Detailed info about the SDK home, development URL, summary, licensing (AGPL-3.0), and maintainers.

🎯 Purpose & Impact

  • Simplified Installation: Users can now install the HUB SDK using Conda, a popular package manager, making the installation process smoother and more integrated with existing Python environments.
  • Wider Accessibility: By supporting Conda, the SDK becomes accessible to a broader audience, including those in data science and academia, where Conda is heavily used.
  • Version Control: Introducing the SDK as a versioned package (0.0.4) helps ensure users can track updates, improvements, and ensure compatibility.

This update marks a significant step toward enhancing user experience and accessibility of the Ultralytics HUB SDK. 🚀

@glenn-jocher
Copy link
Member

@hassaanfarooq01 thanks for the PR, but this is not how we want to do this.

We already have an established Conda workflow, there is no reason to create a completely different and separate workflow for this package. You can see all of this directly in our Docs at the Conda Quickstart section:
https://docs.ultralytics.com/quickstart/#install-ultralytics

Screenshot 2024-03-23 at 15 09 28

The correct process is to establish a feedstock repo (i.e. https://github.com/conda-forge/ultralytics-feedstock/) which will automatically deploy new conda packages on new pip releases as I've done for ultralytics. Please delete this PR and your atlassian doc and follow the established Conda deployment route we already use. Thank you.

@sergiuwaxmann @Burhan-Q

@glenn-jocher glenn-jocher added the invalid This doesn't seem right label Mar 23, 2024
@glenn-jocher
Copy link
Member

@hassaanfarooq01 please delete this branch when you're ready, thank you.

@hassaanfarooq01 hassaanfarooq01 deleted the feat/HUB-547/build-conda-package branch March 25, 2024 09:45
@hassaanfarooq01 hassaanfarooq01 restored the feat/HUB-547/build-conda-package branch March 25, 2024 09:46
@hassaanfarooq01 hassaanfarooq01 deleted the feat/HUB-547/build-conda-package branch March 25, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants