Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIROUTER_MODULE_TOKEN is now a hidden export, but is required in external projects #805

Closed
euangoddard opened this issue Jun 9, 2020 · 5 comments

Comments

@euangoddard
Copy link
Contributor

Prior to version 6.0.2 UIROUTER_MODULE_TOKEN was an injection token that one could import outside the UI router project. Since this release, I get the follow error when trying to import:

import { UIROUTER_MODULE_TOKEN } from '@uirouter/angular/injectionTokens';

Our application relies on this to do:

{ provide: UIROUTER_MODULE_TOKEN, useFactory: STATES_MODULE_FACTORY, deps: [TRANSFORMED_STATES], multi: true },

Could you please allow this token to be imported by external applications again?

@mkoczorowski
Copy link

+1

@kfeinUI
Copy link

kfeinUI commented Jun 19, 2020

This presently breaks @uirouter/angular-hybrid.

Removal of an export is a breaking change done in violation of semantic versioning.

christopherthielen added a commit that referenced this issue Jul 3, 2020
christopherthielen added a commit that referenced this issue Jul 3, 2020
@christopherthielen
Copy link
Member

I'm re-exporting these in #810
Note that these tokens are marked as @hidden and are considered internal implementation details, not public API. Use at your own risk.

@mergify mergify bot closed this as completed in b9c338d Jul 3, 2020
@euangoddard
Copy link
Contributor Author

@christopherthielen many thanks. Do you have a time-frame for a release to that incorporates this change?

@christopherthielen
Copy link
Member

https://github.com/ui-router/angular/releases/tag/6.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants