brings in changes needed for FMS 2021.03 #762
Conversation
* new fv3atm (PR ufs-community#374 3fef1582038a90eb117ada9b62cd546740b335a2) * updated stochastic_physics (PR ufs-community#43 2dfaec8ca47cea9397c1c1e6e6836ce1acaa421a) updates fv3_conf/compile_slurm.IN_gaea to use proper queue with ecflow
…rary results of rerun of regression tests on gaea to confirm
…'t get it correctly
…t get it correctly
|
CI will not pass as fms library update is needed for the container. |
|
Machine: cheyenne |
|
Machine: hera |
|
Machine: cheyenne |
|
Machine: hera |
For example, regional_control test failed because atmos_4xdaily.nc file is different compared to the baseline: |
I see differences in type and some attributes of some variables between these two files: |
|
Updates for the gnu compiler (FV3GFS_io.F90) have been pushed to bensonr/fv3atm and the hash for FV3 (fv3atm) updated. Tests are running on hera for the gnu compiler (RT_COMPILER=gnu and 'rt.sh -l rt_gnu.conf') |
Not sure what was going on there, maybe disk space issues. Will run the tests manually for cheyenne.intel now that the gnu bugfixes for the I/O layer have been pushed. |
I just kicked off |
|
I've run hera.gnu and hera.intel by hand. For hera.gnu, 28 of 33 tests pass. Of the five that fail, three only have atmos_4xdaily.nc differences. The other two are the cpld_* cases and both are completely different. For hera.intel, 67 of 102 tests pass. Of the 35 that fail, seven only have atmos_4xdaily.nc differences. The other 28 are the full set of cpld and datm tests with different answers. What's strange is that all of these tests pass with Intel on Orion, Jet, and Gaea with Intel. |
@DusanJovic-NOAA and I suspect that this has to do with how FMS was compiled. On Gaea, for instance, I compiled FMS with exactly the same compiler flags (in particular no AVX2, as for the previous version) and CPP flags - there, all tests passed. |
|
The following tests failed on wcoss_dell_p3: |
update submodule for FV3 (NOAA-EMC/fv3atm)
updates fv3_conf/compile_slurm.IN_gaea to use proper queue with ecflow
DOES NOT CHANGE ANSWERS
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?
This PR includes updates needed to utilize the latest FMS release 2021.03. This is the initial step to bring in the latest FV3 "the dycore" updates required for advanced nesting capability that includes multiple and telescoping nests working within the regional system.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
This PR is using bensonr/fv3atm :: develop
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs