Rename Fortran variables and CCPP standard names / long names of surface composites from ocean to water

[climbfuji]

PR Checklist

• This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

• This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

• An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
  are specified below.

• If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Description

This PR updates the submodule pointers for the changes described in the associated PRs below.

Note that this PR contains all the changes in #479. #479 can be merged independently before this PR, or as part of this PR.

No baseline changes from this set of PRs (but potentially from #479 as described in that PR).

Issue(s) addressed

Fixes NCAR/ccpp-physics#455.

Testing

Regression tests were run against the existing baselines on hera with Intel and GNU. All tests pass if commit NCAR/ccpp-physics@edc9194 is retained, otherwise the two coupled model runs (fractional and binary mask) using high-res. ocean have slightly different results (see discussion in NCAR/ccpp-physics#596; all other tests still pass).

rt_hera_gnu_against_existing.log
rt_hera_intel_against_existing.log

Final regression testing will be done when it is time for these PRs to go in.

• hera.intel
• hera.gnu
• orion.intel
• cheyenne.intel
• cheyenne.gnu
• gaea.intel
• jet.intel
• wcoss_cray
• wcoss_dell_p3

Dependencies

NCAR/ccpp-physics#609
NOAA-EMC/fv3atm#271
#508

[junwang-noaa]

@climbfuji Please coordinate with physics/wave group on the sfc file output field name changes to check the impact on downstream jobs.

[climbfuji]

As far as I can tell, this affects restart files only - are these used by other applications?

…

On Apr 5, 2021, at 8:07 PM, Jun Wang ***@***.***> wrote: @climbfuji <https://github.com/climbfuji> Please coordinate with physics/wave group on the name sfc file output name changes to check the impact on downstream jobs. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#508 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RNSBDZJCB4EGQRY4A3THJUFPANCNFSM42M3VANA>.

[junwang-noaa]

That is the question for you. On Mon, Apr 5, 2021 at 10:08 PM Dom Heinzeller ***@***.***> wrote:

…

As far as I can tell, this affects restart files only - are these used by other applications? > On Apr 5, 2021, at 8:07 PM, Jun Wang ***@***.***> wrote: > > > @climbfuji <https://github.com/climbfuji> Please coordinate with physics/wave group on the name sfc file output name changes to check the impact on downstream jobs. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub < #508 (comment)>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AB5C2RNSBDZJCB4EGQRY4A3THJUFPANCNFSM42M3VANA >. > — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#508 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI7D6TKGYB2ZIR7BTUOVHZ3THJUKTANCNFSM42M3VANA> .

[climbfuji]

@yangfanglin @SMoorthi-emc I am supposed to find out from the physics and wave groups if changing the name of variables Sfcprop%zorlw to Sfcprop%zorlwav and consecutively Sfcprop%zorlo to Sfcprop%zorlw has any effect on downstream applications. I have no idea whom to ask except the two of you. These changes are in restart files only. Do restart files get used by other applications than the UFS itself? I sincerely hope not, but I would like to get confirmation. If you don't know, can you point me to the right people, please? Thanks very much in advance.

[yangfanglin]

Dom, I checked the code used for current operation (GFS.v16). zorl is written in the surface restart files. zorlo is defined and used in the code but not written out. In the forecast output netcdf files sfcr is surface roughness. zorlw and zorlwav were not defined/used in this code base. They are only found in the latest code base (develop branch). We do have users of restart files, at least for the atmos and sfc. My opinion is that since we are building a new model it is fine to change variable names internal to the model. However, we need to make sure the fields written out in restart and forecast files have consistency. Any product changes take a long time to approve and need to be coordinated with all downstream users. I assume for the coupled model with fractional grids, zorlw, zorlwav, and the "old" zorl will all be written out in the restart file. Will zorl still represent roughness over ALL grid points (composite roughness over fractional grid)? Similarly, will sfcr in the forecast files still represent roughness over ALL grid points ? If the answer is yes, I think the proposed changes are fine. Someone familiar with the WW3 code and wave products should comment on this as well. Fanglin

…

On Mon, Apr 5, 2021 at 10:21 PM Dom Heinzeller ***@***.***> wrote: @yangfanglin <https://github.com/yangfanglin> @SMoorthi-emc <https://github.com/SMoorthi-emc> I am supposed to find out from the physics and wave groups if changing the name of variables Sfcprop%zorlw to Sfcprop%zorlwav and consecutively Sfcprop%zorlo to Sfcprop%zorlw has any effect on downstream applications. I have no idea whom to ask except the two of you. These changes are in restart files only. Do restart files get used by other applications than the UFS itself? I sincerely hope not, but I would like to get confirmation. If you don't know, can you point me to the right people, please? Thanks very much in advance. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#508 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKY5N2J5N3ZG6M6MHWBXYETTHJVPLANCNFSM42M3VANA> .

-- *Fanglin Yang, Ph.D.* *Chief, Model Physics Group* *Modeling and Data Assimilation Branch* *NOAA/NWS/NCEP Environmental Modeling Center* *https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/ <https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/>*

[SMoorthi-emc]

I added zorlw in the latest model because the wave and atmosphere interact.
It should not have any impact on any other model at this time as I don't think restart surface files are not used outside of the model.

[SMoorthi-emc]

zorlw or zorlwav is the field imported on ATM grid from the wave model. It does not go back to WW3. So I don't think it has any impact on WW3. However, we don't have a reproducible restart for the wave model - that is yet to be done. On Mon, Apr 5, 2021 at 11:29 PM Fanglin Yang ***@***.***> wrote:

…

Dom, I checked the code used for current operation (GFS.v16). zorl is written in the surface restart files. zorlo is defined and used in the code but not written out. In the forecast output netcdf files sfcr is surface roughness. zorlw and zorlwav were not defined/used in this code base. They are only found in the latest code base (develop branch). We do have users of restart files, at least for the atmos and sfc. My opinion is that since we are building a new model it is fine to change variable names internal to the model. However, we need to make sure the fields written out in restart and forecast files have consistency. Any product changes take a long time to approve and need to be coordinated with all downstream users. I assume for the coupled model with fractional grids, zorlw, zorlwav, and the "old" zorl will all be written out in the restart file. Will zorl still represent roughness over ALL grid points (composite roughness over fractional grid)? Similarly, will sfcr in the forecast files still represent roughness over ALL grid points ? If the answer is yes, I think the proposed changes are fine. Someone familiar with the WW3 code and wave products should comment on this as well. Fanglin On Mon, Apr 5, 2021 at 10:21 PM Dom Heinzeller ***@***.***> wrote: > @yangfanglin <https://github.com/yangfanglin> @SMoorthi-emc > <https://github.com/SMoorthi-emc> I am supposed to find out from the > physics and wave groups if changing the name of variables Sfcprop%zorlw > to Sfcprop%zorlwav and consecutively Sfcprop%zorlo to Sfcprop%zorlw has > any effect on downstream applications. I have no idea whom to ask except > the two of you. These changes are in restart files only. Do restart files > get used by other applications than the UFS itself? I sincerely hope not, > but I would like to get confirmation. If you don't know, can you point me > to the right people, please? Thanks very much in advance. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #508 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AKY5N2J5N3ZG6M6MHWBXYETTHJVPLANCNFSM42M3VANA > > . > -- *Fanglin Yang, Ph.D.* *Chief, Model Physics Group* *Modeling and Data Assimilation Branch* *NOAA/NWS/NCEP Environmental Modeling Center* *https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/ <https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/>* — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#508 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLVRYXFLGVEZW2NZEWTMFTTHJ5KJANCNFSM42M3VANA> .

-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718 e-mail: ***@***.*** Phone: (301) 683-3718 Fax: (301) 683-3718

[climbfuji]

Thank you, Fanglin and Moorthi, we will proceed with this change.

…

On Apr 6, 2021, at 5:26 AM, SMoorthi-emc ***@***.***> wrote: zorlw or zorlwav is the field imported on ATM grid from the wave model. It does not go back to WW3. So I don't think it has any impact on WW3. However, we don't have a reproducible restart for the wave model - that is yet to be done. On Mon, Apr 5, 2021 at 11:29 PM Fanglin Yang ***@***.***> wrote: > Dom, > > I checked the code used for current operation (GFS.v16). zorl is written > in the surface restart files. zorlo is defined and used in the code but not > written out. In the forecast output netcdf files sfcr is > surface roughness. > > zorlw and zorlwav were not defined/used in this code base. They are only > found in the latest code base (develop branch). > > We do have users of restart files, at least for the atmos and sfc. My > opinion is that since we are building a new model it is fine to change > variable names internal to the model. However, we need to make sure the > fields written out in restart and forecast files have consistency. Any > product changes take a long time to approve and need to be coordinated with > all downstream users. > > I assume for the coupled model with fractional grids, zorlw, zorlwav, and > the "old" zorl will all be written out in the restart file. Will zorl > still represent roughness over ALL grid points (composite roughness over > fractional grid)? Similarly, will sfcr in the forecast files still > represent roughness over ALL grid points ? If the answer is yes, I think > the proposed changes are fine. > > Someone familiar with the WW3 code and wave products should comment on this > as well. > > Fanglin > > > > On Mon, Apr 5, 2021 at 10:21 PM Dom Heinzeller ***@***.***> > wrote: > > > @yangfanglin <https://github.com/yangfanglin> @SMoorthi-emc > > <https://github.com/SMoorthi-emc> I am supposed to find out from the > > physics and wave groups if changing the name of variables Sfcprop%zorlw > > to Sfcprop%zorlwav and consecutively Sfcprop%zorlo to Sfcprop%zorlw has > > any effect on downstream applications. I have no idea whom to ask except > > the two of you. These changes are in restart files only. Do restart files > > get used by other applications than the UFS itself? I sincerely hope not, > > but I would like to get confirmation. If you don't know, can you point me > > to the right people, please? Thanks very much in advance. > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub > > < > #508 (comment) > >, > > or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/AKY5N2J5N3ZG6M6MHWBXYETTHJVPLANCNFSM42M3VANA > > > > . > > > > > -- > *Fanglin Yang, Ph.D.* > *Chief, Model Physics Group* > *Modeling and Data Assimilation Branch* > > *NOAA/NWS/NCEP Environmental Modeling Center* > > *https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/ > <https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/>* > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#508 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ALLVRYXFLGVEZW2NZEWTMFTTHJ5KJANCNFSM42M3VANA> > . > -- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data Assimilation Branch Environmental Modeling Center / National Centers for Environmental Prediction 5830 University Research Court - (W/NP23), College Park MD 20740 USA Tel: (301)683-3718 e-mail: ***@***.*** Phone: (301) 683-3718 Fax: (301) 683-3718 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#508 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RINW7UB6TKMI2VS2RLTHLVXNANCNFSM42M3VANA>.

[climbfuji]

This was merged as part of #520, but didn't get flagged as merged automatically because we do squashed merges in the ufs-weather-model.