Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datm-mom6-cice6 and coupled-model tests on Gaea. #406

Closed

Conversation

binli2337
Copy link
Collaborator

Description

New baseline is created on Gaea for datm-mom6-cice6 and the coupled model. This PR will not change answers for existing tests.

Issue(s) addressed

Testing

What compilers / HPCs was it tested with?
Intel compiler/Gaea

Are the changes covered by regression tests?
Yes.

Dependencies

No.

@binli2337 binli2337 added the Waiting for Reviews The PR is waiting for reviews from associated component PR's. label Feb 2, 2021
@binli2337 binli2337 changed the title Added datm-mom6-cice6 and coupled-model tests on Gaea. Add datm-mom6-cice6 and coupled-model tests on Gaea. Feb 2, 2021
@JessicaMeixner-NOAA
Copy link
Collaborator

Is there any interest in having WW3 ported to Gaea so that the wave tests can also be run there?

@junwang-noaa
Copy link
Collaborator

@JessicaMeixner-NOAA Yes. We can't run tests with ww3 because the ww3 gaea porting changes are not available. Please let us know if ww3 code changes are ready.

@DeniseWorthen
Copy link
Collaborator

The new baselines have been added to the develop-20210128 baseline on Gaea, right?

@climbfuji
Copy link
Collaborator

The new baselines have been added to the develop-20210128 baseline on Gaea, right?

I don't see them there. Bin, if you tell me the location I can copy them over - assuming this goes in as the next PR or at least that there is no other PR with baseline changes in between.

@binli2337
Copy link
Collaborator Author

@climbfuji The baseline location is /lustre/f2/scratch/ncep/Bin.Li/RT/NEMSfv3gfs/develop-20210128/INTEL.

Copy link
Collaborator

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@climbfuji
Copy link
Collaborator

Is this the next PR to go in?

@DeniseWorthen
Copy link
Collaborator

DeniseWorthen commented Feb 2, 2021

It was not intended to be next but I haven't figured out why the cpld_2thread test is not passing w/ the updated FMS. That is the pending commit I believe. The CMEPS update scheduled for 2/5 will not change baselines. Bin Liu told me he wanted to go ahead w/ the CMEPS commit and that their required NEMS commit for HAFS would come later.

@DeniseWorthen
Copy link
Collaborator

Added to PR #401

@binli2337 binli2337 deleted the feature/add_tests_2021 branch May 7, 2021 12:42
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
The SRW_WE2E_COMPREHENSIVE_TESTS variable was incorrectly set by a sh
block that proceeded the call to srw_test.sh. This issue was hidden
because Jenkins sets the parameters to environment variables, which are
accessible from sh blocks. However, the parameters do not seem to be set
as environment variables the first time a multi-branch pipeline is
initialized. This resulted in an unbound variable error when the
SRW_WE2E_COMPREHENSIVE_TESTS variable was accessed by the srw_test.sh
script. This update sets SRW_WE2E_COMPREHENSIVE_TESTS in the same sh
block as the srw_test.sh script call, while ensuring the WORKSPACE
variable isn't evaluated until the sh block.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create baselines on Gaea for the coupled and datm tests
5 participants