Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GFDL Land Model 4.0 #2146

Merged
merged 188 commits into from
Oct 11, 2024
Merged

Conversation

JustinPerket
Copy link
Contributor

@JustinPerket JustinPerket commented Feb 23, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Introduces the GFDL Land Model version 4.0 (LM4.0) with NUOPC Driver. Functional but not scientically valid for Data Atmosphere mode with CDEPS.

Adds these two nested submodules:

Commit Message:

* UFSWM - Adds GFDL Land Model version 4 (LM4) as a component model, functional in Data Atmosphere mode
  * CMEPS - Small modifications for coupling of LM4
 * LM4-NUOPC driver - new model component hosted at github.com/NOAA-GFDL/LM4-NUOPC-driver. NUOPC Cap for LM4
   * LM4.0 - submodule of LM4 NUOPC driver, hosted at https://github.com/NOAA-GFDL/LM4/
 

Priority:

  • Normal

Git Tracking

UFSWM:

  • No current Issue (TBD?)

Sub component Pull Requests:

New Sub components:


Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR should not affect existing Tests/Baselines.

Input data Changes:

LM4 copies input data files from @[INPUTDATA_LM4] , a temporary development variable for path to GFDL data. It is set in rt.sh for these machines:

  • Gaea: INPUTDATA_LM4=${INPUTDATA_LM4:-/gpfs/f5/gfdl/world-shared/cmip6/datasets/CM4/common}
  • Hera: INPUTDATA_LM4=${INPUTDATA_LM4:-/scratch2/GFDL/gfdlscr/Justin.Perket/cmip6/datasets/CM4/common}
  • Orion: INPUTDATA_LM4=${INPUTDATA_LM4:-/work/noaa/gfdlscr/pdata/gfdl/cmip6/datasets/CM4/common}

UFS's grid_spec.nc references aXl mosaic tile files that are required by LM4, but are not included in current UFS input paths.
Therefore in development, this untars @[INPUTDATA_LM4]/c96_grid/c96_OM4_025_grid_No_mg_drag_v20160808.tar for consistent grid_spec.nc and related files

Additionally, the following files are needed by LM4:

  @[INPUTDATA_LM4]/c96_LM4/c96_topo_rough_land.nc.tar
  @[INPUTDATA_LM4]/common_LM4/biodata.nc
  @[INPUTDATA_LM4]/common_LM4/cover_type.nc
  @[INPUTDATA_LM4]/common_LM4/geohydrology.nc
  @[INPUTDATA_LM4]/common_LM4/geohydrology_table_2a2n.nc 
  @[INPUTDATA_LM4]/common_LM4/ground_type.nc
  @[INPUTDATA_LM4]/common_LM4/landuse.nc
  @[INPUTDATA_LM4]/common_LM4/soil_brdf.nc
  @[INPUTDATA_LM4]/common_LM4/soil_type_hwsd_5minute.nc -> ./INPUT/soil_type.nc

Library Changes/Upgrades:

For UFS-LM4 to be functional in Debug Mode, currently a Debug version of FMS is needed. JCSDA/spack-stack#1288 addresses this.


Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Oct 9, 2024

@JustinPerket running the new case with standard base ./opnReqTest -n datm_cdeps_lm4_gswp3 -a epic -c std , I receive the below error.

cases to run: std_base /scratch1/NCEPDEV/stmp2/Zachary.Shrader/rt-2146/tests/opnReqTests/wrt_env.sh: line 1: OUTPUT_FH: unbound variable

@zach1221 I think it's different issue to address general application capability of ORT system. datm_cdeps_lm4_gswp3 is not necessary for operational requirement. I don't think ORT OUTPUT_FH issue is specifically related to this spr.

@JustinPerket
Copy link
Contributor Author

@JustinPerket running the new case with standard base ./opnReqTest -n datm_cdeps_lm4_gswp3 -a epic -c std , I receive the below error.

cases to run: std_base /scratch1/NCEPDEV/stmp2/Zachary.Shrader/rt-2146/tests/opnReqTests/wrt_env.sh: line 1: OUTPUT_FH: unbound variable

I remember getting a similar error yesterday, and also when running datm_cdeps_lnd_gswp3 to compare. But I was not certain I was using opnReqTest correctly.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Oct 9, 2024

ORT script system is quite hard wired and far from being perfect.

@FernandoAndrade-NOAA
Copy link
Collaborator

I do not have permission to push RT logs to this branch, please add permissions for @zach1221 and I, @JustinPerket

@JustinPerket
Copy link
Contributor Author

Invites should be sent

I do not have permission to push RT logs to this branch, please add permissions for @zach1221 and I, @JustinPerket

@JustinPerket
Copy link
Contributor Author

I was also rerunning RTs on Hera, but it'll take quite a while for me to get through the queue.

@BrianCurtis-NOAA
Copy link
Collaborator

WCOSS2 and Acorn RT Logs on Hera at: /scratch1/NCEPDEV/stmp2/Brian.Curtis

@FernandoAndrade-NOAA
Copy link
Collaborator

Ok, we should be good to go, I'll let the sub PR know to continue with the merge.

@FernandoAndrade-NOAA
Copy link
Collaborator

Sub PR is merged in, please go ahead and revert the related gitmodules change and update the commit, thank you.

@jkbk2004
Copy link
Collaborator

@JustinPerket Note that CMEPS new hash is NOAA-EMC/CMEPS@24e9eed

@JustinPerket
Copy link
Contributor Author

@JustinPerket Note that CMEPS new hash is NOAA-EMC/CMEPS@24e9eed

Thanks! (Sorry, I was out of the office yesterday)

@jkbk2004 jkbk2004 merged commit f3ce169 into ufs-community:develop Oct 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Baselines New baselines will be added to project. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants