Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WW3: Fix Intel CI #1890

Merged
merged 7 commits into from
Sep 12, 2023

Conversation

MatthewMasarik-NOAA
Copy link
Collaborator

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
    • LOG: Please see note below in section, Regression Tests.
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

This PR applies a fix to the Intel Github CI workflow. The GNU workflow is also updated at the same time.

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Subcomponent Pull Requests

Blocking Dependencies

None.

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

Note: The regression tests have not been run because the only changes this PR introduces are restricted to the Github CI workflow. Regression tests would not exercise any of that code. That said I can run them no problem if having the logs as proof is useful. Please let me know if so.

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@MatthewMasarik-NOAA MatthewMasarik-NOAA changed the title Dev ufs/bugfix/ci WW3: Fix Intel CI Sep 7, 2023
@BrianCurtis-NOAA BrianCurtis-NOAA added the No Baseline Change No Baseline Change label Sep 11, 2023
@github-actions
Copy link

@MatthewMasarik-NOAA please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date
  • fv3 NOT up to date
  • stoch NOT up to date

@BrianCurtis-NOAA
Copy link
Collaborator

@jkbk2004 this is a good PR to merge with another as it does not change baselines and is just a hash change. It seems ready to go.

@MatthewMasarik-NOAA
Copy link
Collaborator Author

MatthewMasarik-NOAA commented Sep 11, 2023

@MatthewMasarik-NOAA please bring these up to date with respective authoritative repositories

@BrianCurtis-NOAA thanks for syncing my branch.

@jkbk2004
Copy link
Collaborator

@jkbk2004 this is a good PR to merge with another as it does not change baselines and is just a hash change. It seems ready to go.

Sure! We can merge after a quick sanity check. @zach1221 @FernandoAndrade-NOAA FYI

@zach1221
Copy link
Collaborator

@jkbk2004 this is a good PR to merge with another as it does not change baselines and is just a hash change. It seems ready to go.

Sure! We can merge after a quick sanity check. @zach1221 @FernandoAndrade-NOAA FYI

Ok, I'll run the regression tests on Hera then and we can move forward after that.

@zach1221
Copy link
Collaborator

zach1221 commented Sep 11, 2023

@MatthewMasarik-NOAA ok the sanity check has been complete on Hera, and RT logs posted. We can begin the merging process now. I'll follow up on the WW3 PR for it to be merged.

@JessicaMeixner-NOAA
Copy link
Collaborator

The WW3 PR has been merged.

@zach1221
Copy link
Collaborator

@MatthewMasarik-NOAA WW3 PR #1069 is merged. Please update submodule pointer and revert the .gitmodule url.
hash: 97e6a63ebf9a9030fcdae6ad5cf85a0bc91fa37f

@MatthewMasarik-NOAA
Copy link
Collaborator Author

@MatthewMasarik-NOAA WW3 PR #1069 is merged. Please update submodule pointer and revert the .gitmodule url. hash: 97e6a63ebf9a9030fcdae6ad5cf85a0bc91fa37f

@zach1221 OK, will do

@MatthewMasarik-NOAA
Copy link
Collaborator Author

MatthewMasarik-NOAA commented Sep 12, 2023

@zach1221 Should be set

update: whoops, i see i made a mistake on the submodule pointer. i'm correcting it right now

@MatthewMasarik-NOAA
Copy link
Collaborator Author

Resolved.

@zach1221 zach1221 merged commit e7934cf into ufs-community:develop Sep 12, 2023
@MatthewMasarik-NOAA MatthewMasarik-NOAA deleted the dev-ufs/bugfix/ci branch March 13, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WW3: fix Intel CI
6 participants