-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
creating a branch for PR #183
creating a branch for PR #183
Conversation
.gitmodules
Outdated
[submodule "NEMS"] | ||
path = NEMS | ||
url = https://github.com/NOAA-EMC/NEMS | ||
branch = develop | ||
[submodule "FMS"] | ||
path = FMS | ||
url = https://github.com/NOAA-GFDL/FMS | ||
branch = master | ||
branch = 2019.01.03-release-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the name of the FMS branch changed?
As I understand that is the version that works for both ufs-s2s-model and ufs-weather-model. |
Your branch is using this FMS commit:
which is tag 2019.01.03, and it's exact commit used by ufs-s2s-model. The branch you are referring to in .gitmodules ( |
when I changed back to master I get
"f7f1c1c73c1f478a53e84caee6aff2fa840ad086 FMS (2020.03-beta1)"
Is this correct?
Thanks
Moorthi
…On Mon, Aug 10, 2020 at 9:42 AM Dusan Jovic ***@***.***> wrote:
As I understand that is the version that works for both ufs-s2s-model and
ufs-weather-model.
I don't know if master has been changed to that version - if master can
run with s2s, then it can be changed, but I am not aware of it.
Your branch is using this FMS commit:
$ git submodule status .
f61416fef691d9ba39a40df1ce72aa574f54c390 FMS (2019.01.03)
which is tag 2019.01.03, and it's exact commit used by ufs-s2s-model. The
branch you are referring to in .gitmodules (2019.01.03-release-in-progress)
has already been merged to master. Please change this back to master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#183 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYT2EGMG5Y7JDEISUVTR772NLANCNFSM4PZOE2AQ>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: Shrinivas.Moorthi@noaa.gov
Phone: (301) 683-3718 Fax: (301) 683-3718
|
Can you go to directory This should give you
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. We can merge ccpp-physics, but I would like to hear from Arun and Bao about the fv3atm PR before we merge that one.
@DusanJovic-NOAA @SMoorthi-emc Is it possible to pull in this tiny PR that changes only This would be the instructions:
No problem if not, we can make it part of the next PR, too. Thanks, Dom |
Dom,
I have no problem doing this if Dusan agrees.
Moorthi
…On Thu, Aug 13, 2020 at 12:15 PM Dom Heinzeller ***@***.***> wrote:
@DusanJovic-NOAA <https://github.com/DusanJovic-NOAA> @SMoorthi-emc
<https://github.com/SMoorthi-emc> Is it possible to pull in this tiny PR
that changes only rt_cheyenne.conf and does not require running any tests
again?
#185 <#185>
This would be the instructions:
# in ufs-weather-model
git remote add dom https://github.com/climbfuji/ufs-weather-model
git remote update
git cherry-pick 52d86f2
# then push to your fork to update the PR
No problem if not, we can make it part of the next PR, too.
Thanks,
Dom
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#183 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYWJAG3Y6D4HCBQOXPDSAQGRVANCNFSM4PZOE2AQ>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: Shrinivas.Moorthi@noaa.gov
Phone: (301) 683-3718 Fax: (301) 683-3718
|
Sure. Go ahead, pull #185. |
OK, it is done. Hopefully, it is correct.
Moorthi
On Thu, Aug 13, 2020 at 1:05 PM Dusan Jovic <notifications@github.com>
wrote:
… Dom, I have no problem doing this if Dusan agrees. Moorthi
… <#m_-636279043545485159_>
On Thu, Aug 13, 2020 at 12:15 PM Dom Heinzeller *@*.***> wrote:
@DusanJovic-NOAA <https://github.com/DusanJovic-NOAA>
https://github.com/DusanJovic-NOAA @SMoorthi-emc
<https://github.com/SMoorthi-emc> https://github.com/SMoorthi-emc Is it
possible to pull in this tiny PR that changes only rt_cheyenne.conf and
does not require running any tests again? #185
<#185> <#185
<#185>> This would
be the instructions: # in ufs-weather-model git remote add dom
https://github.com/climbfuji/ufs-weather-model git remote update git
cherry-pick 52d86f2
<52d86f2>
# then push to your fork to update the PR No problem if not, we can make it
part of the next PR, too. Thanks, Dom — You are receiving this because you
were mentioned. Reply to this email directly, view it on GitHub <#183
(comment)
<#183 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALLVRYWJAG3Y6D4HCBQOXPDSAQGRVANCNFSM4PZOE2AQ
.
-- Dr. Shrinivas Moorthi Research Meteorologist Modeling and Data
Assimilation Branch Environmental Modeling Center / National Centers for
Environmental Prediction 5830 University Research Court - (W/NP23), College
Park MD 20740 USA Tel: (301)683-3718 e-mail: ***@***.***
Phone: (301) 683-3718 Fax: (301) 683-3718
Sure. Go ahead, pull #185
<#185>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#183 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYUHJE6QQIQPU6QIBDTSAQMNHANCNFSM4PZOE2AQ>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: Shrinivas.Moorthi@noaa.gov
Phone: (301) 683-3718 Fax: (301) 683-3718
|
Thanks, perfect! |
* replace #ifdef OPENMP with #ifdef _OPENMP * OpenMP link libraries * fix typos and missing stuff * clean up compile defs * move CCPP code generator call to FV3, where it belongs * install targets are updated * minor cleanups
Adding a Jinja Templating tool for Rocoto.
* Modify workflow environment for orion * update build env for orion * Update env scripts * Update hash of regional workflow Co-authored-by: Chan-Hoo Jeon <chjeon@Orion-login-1.HPC.MsState.Edu> Co-authored-by: Chan-Hoo Jeon <chjeon@Orion-login-2.HPC.MsState.Edu>
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
This PR updates fv3atm and ccpp-physics (see PRs Sm jul302020 #155 and Sm jul302020 #486)
What bug does it fix, or what feature does it add?
This PR fixes several bugs and adds update for the atmosphere/ww3 two way coupling.
It adds new variables for z0 over land, ice and water which makes the coupled model with fractional grid to reproduce with respect to restart and continuous runs, with both the NEMS mediator and CMEPS.
Is a change of answers expected from this PR?
Yes
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Yes
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs