-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade FMS to 2019.01.03 #179
Downgrade FMS to 2019.01.03 #179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good to me. I noticed that the atmos_4xdaily files are still there, so I assume we will have another commit to clean up that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - I'll try this code on cheyenne while we are waiting for hera to come back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested killing jobs on Cheyenne and it seems to work:
kill -15
on the rt.sh job kills all jobs in the queue- hitting
Ctrl + C
from the rt.sh job itself doesn't kill the queued jobs (is this intended?)
To complete the testing, I ran the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Description
Downgrade FMS to 2019.01.03.
Small changes in cmake build system due to FMS version change.
Improve error handling in rt.sh when ecflow is used. Scripts cleanup and refactoring.
Issue(s) addressed
In order to merge (unify) ufs-weather-model and ufs-s2s-model changing the FMS to the exact version used by s2s is required.
Testing
Regression test will be performed on all Tier-1 platforms.
New baseline (develop-20200805) has been created, because of file format change in FMS (CDF2 to HDF5). All restart files and all history files (created using write component) are bit-identical.
Dependencies
N/A