Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade FMS to 2019.01.03 #179

Merged
merged 11 commits into from
Aug 5, 2020

Conversation

DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA DusanJovic-NOAA commented Aug 4, 2020

Description

Downgrade FMS to 2019.01.03.
Small changes in cmake build system due to FMS version change.
Improve error handling in rt.sh when ecflow is used. Scripts cleanup and refactoring.

Issue(s) addressed

In order to merge (unify) ufs-weather-model and ufs-s2s-model changing the FMS to the exact version used by s2s is required.

Testing

Regression test will be performed on all Tier-1 platforms.
New baseline (develop-20200805) has been created, because of file format change in FMS (CDF2 to HDF5). All restart files and all history files (created using write component) are bit-identical.

Dependencies

N/A

Copy link
Collaborator

@junwang-noaa junwang-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me. I noticed that the atmos_4xdaily files are still there, so I assume we will have another commit to clean up that.

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I'll try this code on cheyenne while we are waiting for hera to come back.

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested killing jobs on Cheyenne and it seems to work:

  • kill -15 on the rt.sh job kills all jobs in the queue
  • hitting Ctrl + C from the rt.sh job itself doesn't kill the queued jobs (is this intended?)

@climbfuji
Copy link
Collaborator

To complete the testing, I ran the rt_gnu.conf tests on Cheyenne against the old/existing baseline. All tests ran to completion within the walltime used usually for cheyenne.gnu but "failed" as expected, due to differences in atmos_4xdaily*.nc. All good to go!

Copy link
Contributor

@MinsukJi-NOAA MinsukJi-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@DusanJovic-NOAA DusanJovic-NOAA merged commit 6e4972b into ufs-community:develop Aug 5, 2020
@DusanJovic-NOAA DusanJovic-NOAA deleted the rt_kill branch August 5, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants