Create ESMF field attributes using the same kind as field data values

[DusanJovic-NOAA]

Description

This PR fixes the mismatch between ESMF field attributes and field data values types in fv3atm history files, and prevents model failure when ESMF v8.4.0 is used due to type mismatch check in underlying PIO library.

Top of commit queue on: TBD

Input data additions/changes

• No changes are expected to input data.
• There will be new input data.
• Input data will be updated.

Anticipated changes to regression tests:

• No changes are expected to any regression test.
• Changes are expected to the following tests:

Netcdf filed attributes (_FillValue and missing_value) will be changed but regression tests should pass with ALT_CHECK......OK. No changes in actual data values are expected.

Subcomponents involved:

• AQM
• CDEPS
• CICE
• CMEPS
• CMakeModules
• FV3
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Combined with PR's (If Applicable):

Commit Queue Checklist:

• Link PR's from all sub-components involved
• Confirm reviews completed in sub-component PR's
• Add all appropriate labels to this PR.
• Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
• Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Depends on NOAA-EMC/fv3atm#618
Closes #1564

Testing Day Checklist:

• This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
• Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

• RDHPCS
  • Intel
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • GNU
    • Hera
    • Cheyenne
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment

[jkbk2004]

@DusanJovic-NOAA we can start working on this pr. Can you sync up branch? we are considering to add regional_control to ci.test. @zach1221 can you create a pr to Dusan's branch to add in ci.test change?

[DusanJovic-NOAA]

@DusanJovic-NOAA we can start working on this pr. Can you sync up branch? we are considering to add regional_control to ci.test. @zach1221 can you create a pr to Dusan's branch to add in ci.test change?

I just synced my branches with develop.

[zach1221]

@jkbk2004 I have created the PR for jenkins-ci regional_control.

[jkbk2004]

@zach1221 thanks! @DusanJovic-NOAA can you merge in Zach's pr to your branch?

[DusanJovic-NOAA]

@zach1221 thanks! @DusanJovic-NOAA can you merge in Zach's pr to your branch?

Merged.

[BrianCurtis-NOAA]

@jkbk2004 Please don't forget, we now require that upstream PR's are reviewed PRIOR to being allowed in the commit queue. This PR has not passed that requirement!

[BrianCurtis-NOAA]

Also, we should be getting the UFSWM PR reviewed prior to commit queue as well.

[jkbk2004]

Also, we should be getting the UFSWM PR reviewed prior to commit queue as well.

Sure! Thanks for reminding!

[jkbk2004]

Code change only on fv_nggps_diag.f90 at the cubed sphere fvGFS driver level. The dependency NOAA-GFDL/GFDL_atmos_cubed_sphere#236 was approved. We can go ahead to review and approve for the pr.

[BrianCurtis-NOAA]

On Dogwood there is an issue with compiles going over the wallclock, but when I run them manually they run in 10-15 minutes, well before the wallclock.

[BrianCurtis-NOAA]

I will try one last time. Then I will skip and we can merge. It seems a random issue server side, not from the code.

[jkbk2004]

I will try one last time. Then I will skip and we can merge. It seems a random issue server side, not from the code.

sure!

[BrianCurtis-NOAA]

It seems the transition to dogwood or cactus seems to make RT's run a little weird. Please skip Dogwood and Acorn. I need to look into what's going on with more time available.

[jkbk2004]

@DusanJovic-NOAA NOAA-EMC/fv3atm#618 was merged.