small cloud tuning from Greg Thompson #1410
Conversation
|
@grantfirl we are trying to see if we can add in fms upgrade (g2tmpl and crtm as well). One or two days delay is possible for this pr. Also, Dustin's #1394 is on hold. But we are giving a priority for emc ccpp fork branch switch after #1394. So schedules for ccpp prs a bit tangled. If progress can be made on #1394, commit schedule issue can be resolved very nicely. But I will check with emc code managers. |
|
@grantfirl Is this ready to get tested today? |
|
@BrianCurtis-NOAA @ChunxiZhang-NOAA The underlying physics code changes are certainly ready to test, although it looks like there will be an issue testing this because the ccpp-physics PR is into the ufs/dev branch right now, and the ufs/dev branch is behind NCAR/main. I think that the PRs that were merged into NCAR/main since ufs/dev was forked off have changed some baselines, so the UFS RTs will basically be testing old code against newer baselines, which, I'm guessing, is no good. @ChunxiZhang-NOAA We could change the target of the ccpp-physics PR back into NCAR/main if @BrianCurtis-NOAA would like to work on this today. I know that you wanted to merge Dustin's "accumulated cleanup" PR into NCAR/main before syncing, but I'm not sure that it is ready yet, so perhaps we should just change the target of the Thompson tuning PR to avoid delaying EMC code managers? |
|
@BrianCurtis-NOAA FYI, I have a doctor's appointment for the next hour or so, but will be back to help after 11 ET. |
|
@grantfirl It sounds like getting UFS using ufs-community/ccpp-physics should be a higher priority? @ChunxiZhang-NOAA Is this something you could get done by tomorrow? |
|
@grantfirl @BrianCurtis-NOAA I thought this PR would be merged AFTER the fv3atm pointed to ufs-community/ccpp-physics ufs/dev branch. Currently, I am still waiting for Dustin's PR#956. If this PR is not ready by the end of day today, I will just go ahead and sync the ufs/dev branch with NCAR/main, then create a PR to make fv3atm point to ufs/dev. |
|
@ChunxiZhang-NOAA @jkbk2004 @grantfirl I suggest to proceed without#956. |
|
@dustinswales @jkbk2004 @grantfirl Ok, I will start the transition process without #956. |
You may want to compare the outputs manually. It may lead you into finding if its a code issue or if new baselines need to be generated because of your changes. |
|
@BrianCurtis-NOAA All of the submodules have been updated after Chunxi made the switch to use the ufs-community/ufs/dev branch of ccpp-physics. This should be ready to test now if you'd like to return to it. |
This change properly parallelizes the ORT workflow using the Jenkins matrix and agent directives, which eliminates the need for the ufs-weather-model/ort-docker-pipeline job and change request handling.
|
@grantfirl There is still time. But we are considering to merge in #1453 to this PR. Its just one file change on jenkinsfile that has no impact to other tests. |
@jkbk2004 OK, that is fine with me. I'm waiting to update the PR branches associated with this one until #1437 is merged. If you would like me to update beforehand, just let me know. |
|
@grantfirl thanks so much! please, go ahead to combine in the change in @jessemcfarland #1453. I think it makes a sense to prepare since today is Friday. #1437 is a bit heavy pr. |
|
@jkbk2004 This PR and its submodule PRs have been updated to the latest development code, so it should be ready to test. |
|
@grantfirl @BrianCurtis-NOAA I will be away from desk next a few hours. Can you add new BL_DATE=20221017? |
|
@grantfirl Your on the top of the commit queue. Please update to the latest develop in UFSWM and change the BL_DATE in rt.sh to 20221017. |
|
OK, @BrianCurtis-NOAA I'll do this now. |
|
Automated RT Failure Notification |
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
|
Automated RT Failure Notification |
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
|
We will skip the test on Cheyenne. It will be down until Oct. 20. @grantfirl we can start merging process. |
OK, will do. |
|
NOAA-EMC/fv3atm#580 is ready for review/merge. |
|
Jenkins-ci logs attached. |
|
@grantfirl we can merge in here with fv3atm hash update and reverting branch in gitmodules. |
|
@ChunxiZhang-NOAA @DusanJovic-NOAA We will skip cheyenne for this pr. Can you go ahead to approve? |
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Description
This PR only updates the FV3 and ccpp/physics submodule pointer to include new cloud tuning for ice clouds aloft by Greg Thompson.
Issue(s) addressed
NCAR/ccpp-physics#966
Testing
The changes were tested using rt.conf on Hera/Intel. All tests pass except for those using the Thompson MP scheme, which fail in run_result as expected due to the new tuning.
Dependencies
ufs-community/ccpp-physics#1
NOAA-EMC/fv3atm#580