Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rectify total number of Thompson MP species and add UFS-Aerosols to S2S and S2SW #1118

Merged
Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
e4c4121
Point FV3 submodule to forked repository.
rmontuoro Mar 15, 2022
71dbf85
Merge branch 'develop' into bugfix/thompson-tracer-index
rmontuoro Mar 16, 2022
9b1fc6d
Add UFS-Aerosol to CMake build apps S2S and S2SW.
rmontuoro Mar 16, 2022
f912769
Merge branch 'develop' into bugfix/thompson-tracer-index
rmontuoro Mar 18, 2022
895bc65
Implement S2SWA build app as the only one enabling prognostic aerosol…
rmontuoro Mar 18, 2022
666b5b3
Re-add S2SA build app to enable prognostic aerosols without waves.
rmontuoro Mar 18, 2022
3cda209
Use S2SA and S2SWA build apps in regression test configuration file.
rmontuoro Mar 18, 2022
3347ddd
Update output_fh documentation.
rmontuoro Mar 18, 2022
767f523
Add S2SA and S2SWA to list of valid build applications.
rmontuoro Mar 21, 2022
407f2bb
Update regression test baseline date to 20220321.
rmontuoro Mar 21, 2022
4eba43f
[AutoRT] cheyenne.gnu Job Completed.
BrianCurtis-NOAA Mar 21, 2022
4358e59
[AutoRT] orion.intel Job Completed.
BrianCurtis-NOAA Mar 21, 2022
a924a29
[AutoRT] hera.intel Job Completed.
BrianCurtis-NOAA Mar 21, 2022
d7209eb
[AutoRT] cheyenne.intel Job Completed.
BrianCurtis-NOAA Mar 21, 2022
709e193
[AutoRT] jet.intel Job Completed.
BrianCurtis-NOAA Mar 21, 2022
23182d2
[AutoRT] gaea.intel Job Completed.
BrianCurtis-NOAA Mar 21, 2022
4d3cee1
[AutoRT] hera.gnu Job Completed.
BrianCurtis-NOAA Mar 21, 2022
f675eb0
Add regression test logs from WCOSS Cray & Dell P3
rmontuoro Mar 22, 2022
f9355a8
Update FV3 submodule.
rmontuoro Mar 22, 2022
5568b83
Update FV3 submodule to point to authoritative repository.
rmontuoro Mar 22, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[submodule "FV3"]
path = FV3
url = https://github.com/NOAA-EMC/fv3atm
branch = develop
url = https://github.com/rmontuoro/fv3atm
branch = bugfix/thompson-tracer-index
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmontuoro Please make an fv3atm PR, we need to merge your bugfix/thompson-tracer-index branch to emc develop branch.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See PR#509.

[submodule "WW3"]
path = WW3
url = https://github.com/NOAA-EMC/WW3
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ list(APPEND CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR}/CMakeModules/Modules)
###############################################################################

# Valid applications and choices
list(APPEND VALID_APPS ATM ATMAERO ATMW S2S S2SW HAFS HAFSW HAFS-ALL NG-GODAS)
list(APPEND VALID_APPS ATM ATMAERO ATMW S2S S2SA S2SW S2SWA HAFS HAFSW HAFS-ALL NG-GODAS)
set(APP NONE CACHE BOOL "Application Name")
if(NOT (APP IN_LIST VALID_APPS))
message(FATAL_ERROR "${APP} is not a valid application.\nValid Applications are: ${VALID_APPS}")
Expand Down
2 changes: 1 addition & 1 deletion FV3
Submodule FV3 updated 2 files
+2 −2 .gitmodules
+1 −1 ccpp/physics
18 changes: 13 additions & 5 deletions cmake/configure_apps.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -35,19 +35,27 @@ if(APP MATCHES "^(NG-GODAS)$")
message("Configuring UFS app in (CDEPS) Data Atmosphere mode")
endif()

if(APP MATCHES "^(S2S|S2SW)$")
if(APP MATCHES "^(S2S|S2SA|S2SW|S2SWA)$")
set(APP_MSG "Configuring UFS app in S2S")
set(CMEPS ON CACHE BOOL "Enable CMEPS" FORCE)
set(FMS ON CACHE BOOL "Enable FMS" FORCE)
set(FV3 ON CACHE BOOL "Enable FV3" FORCE)
set(MOM6 ON CACHE BOOL "Enable MOM6" FORCE)
set(CICE6 ON CACHE BOOL "Enable CICE6" FORCE)
set(STOCH_PHYS ON CACHE BOOL "Enable Stochastic Physics" FORCE)
if(APP MATCHES "S2SW")
if(APP MATCHES "^S2SW")
set(WW3 ON CACHE BOOL "Enable WAVEWATCH III" FORCE)
message("Configuring UFS app in S2S with Waves mode")
else()
message("Configuring UFS app in S2S mode")
string(CONCAT APP_MSG ${APP_MSG} " with Waves")
endif()
if(APP MATCHES "A$")
set(UFS_GOCART ON CACHE BOOL "Enable GOCART" FORCE)
if(WW3)
string(CONCAT APP_MSG ${APP_MSG} " and Aerosols")
else()
string(CONCAT APP_MSG ${APP_MSG} " with Aerosols")
endif()
endif()
message("${APP_MSG} mode")
endif()

if(APP MATCHES "^(HAFS|HAFSW|HAFS-ALL)$")
Expand Down
1 change: 1 addition & 0 deletions doc/UsersGuide/source/InputsOutputs.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1206,6 +1206,7 @@ shows the following parameters that can be set in *model_configure* at run-time.
- history file output forecast hours or history file output frequency if the second elelment is -1
- real
- -1 (negative: turn off the option, otherwise overwritten nfhout/nfhout_fh; 6 -1: output every 6 hoursr; 6 9: output history files at fh=6 and 9)
- -1 (negative: turn off the option, otherwise overwritten nfhout/nfhout_fh; 6 -1: output every 6 hoursr; 6 9: output history files at fh=6 and 9. Note: output_fh can only take 277 elements)

:numref:`Table %s <ModelConfigParamsNotChanged>` shows the following parameters in *model_configure* that
are not usually changed.
Expand Down
320 changes: 160 additions & 160 deletions tests/RegressionTests_cheyenne.gnu.log

Large diffs are not rendered by default.

1,036 changes: 518 additions & 518 deletions tests/RegressionTests_cheyenne.intel.log

Large diffs are not rendered by default.

1,070 changes: 533 additions & 537 deletions tests/RegressionTests_gaea.intel.log

Large diffs are not rendered by default.

318 changes: 159 additions & 159 deletions tests/RegressionTests_hera.gnu.log

Large diffs are not rendered by default.

1,048 changes: 524 additions & 524 deletions tests/RegressionTests_hera.intel.log

Large diffs are not rendered by default.

932 changes: 466 additions & 466 deletions tests/RegressionTests_jet.intel.log

Large diffs are not rendered by default.

1,032 changes: 516 additions & 516 deletions tests/RegressionTests_orion.intel.log

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions tests/rt.conf
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# S2S tests #
###################################################################################################################################################################################

COMPILE | -DAPP=S2SW -DUFS_GOCART=ON -DCCPP_SUITES=FV3_GFS_v16_coupled_nsstNoahmpUGWPv1,FV3_GFS_v16_coupled_p7_rrtmgp,FV3_GFS_v17_coupled_p8 | - wcoss_cray | fv3 |
COMPILE | -DAPP=S2SWA -DCCPP_SUITES=FV3_GFS_v16_coupled_nsstNoahmpUGWPv1,FV3_GFS_v16_coupled_p7_rrtmgp,FV3_GFS_v17_coupled_p8 | - wcoss_cray | fv3 |
RUN | cpld_control_p8 | - wcoss_cray | fv3 |
RUN | cpld_2threads_p8 | - wcoss_cray | |
RUN | cpld_decomp_p8 | - wcoss_cray jet.intel | |
Expand All @@ -24,7 +24,7 @@ RUN | cpld_restart_c192_p8
RUN | cpld_control_c384_p8 | - wcoss_cray jet.intel | fv3 |
RUN | cpld_restart_c384_p8 | - wcoss_cray jet.intel | | cpld_control_c384_p8

COMPILE | -DAPP=S2S -DDEBUG=ON -DUFS_GOCART=ON -DCCPP_SUITES=FV3_GFS_v17_coupled_p8 | - wcoss_cray | fv3 |
COMPILE | -DAPP=S2SA -DDEBUG=ON -DCCPP_SUITES=FV3_GFS_v17_coupled_p8 | - wcoss_cray | fv3 |
RUN | cpld_debug_p8 | - wcoss_cray | fv3 |

###################################################################################################################################################################################
Expand Down
2 changes: 1 addition & 1 deletion tests/rt.sh
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ if [[ $TESTS_FILE =~ '35d' ]] || [[ $TESTS_FILE =~ 'weekly' ]]; then
TEST_35D=true
fi

BL_DATE=20220318
BL_DATE=20220321
if [[ $MACHINE_ID = hera.* ]] || [[ $MACHINE_ID = orion.* ]] || [[ $MACHINE_ID = cheyenne.* ]] || [[ $MACHINE_ID = gaea.* ]] || [[ $MACHINE_ID = jet.* ]] || [[ $MACHINE_ID = s4.* ]]; then
RTPWD=${RTPWD:-$DISKNM/NEMSfv3gfs/develop-${BL_DATE}/${RT_COMPILER^^}}
else
Expand Down