Skip to content

Commit

Permalink
[develop] Fixed issue #649 and tested on cheyenne. (#650)
Browse files Browse the repository at this point in the history
This fixes a problem due to a typo that places the '-n ${NUMTS}' argument before the gefs2lbc_para executable instead of after on Cheyenne for the AQM_LBCS task. The typo causes mpirun to fail on Cheyenne because it's an invalid mpirun argument.

---------

Co-authored-by: Paddy Mccarthy <paddy@cheyenne1.cheyenne.ucar.edu>
Co-authored-by: Paddy Mccarthy <paddy@cheyenne6.cheyenne.ucar.edu>
  • Loading branch information
3 people authored Mar 10, 2023
1 parent 550f400 commit 86c3eb0
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/exregional_aqm_lbcs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ Please ensure that you've built this executable."
#----------------------------------------------------------------------
#
PREP_STEP
eval ${RUN_CMD_UTILS} -n ${NUMTS} ${exec_fp} ${REDIRECT_OUT_ERR} || \
eval ${RUN_CMD_AQMLBC} ${exec_fp} ${REDIRECT_OUT_ERR} || \
print_err_msg_exit "\
Call to executable (exec_fp) to generate chemical and GEFS LBCs
file for RRFS-CMAQ failed:
Expand Down
4 changes: 4 additions & 0 deletions ush/config_defaults.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -199,13 +199,17 @@ platform:
# RUN_CMD_AQM:
# The run command for some AQM tasks.
#
# RUN_CMD_AQMLBC:
# The run command for the AQM_LBCS task.
#
#-----------------------------------------------------------------------
#
RUN_CMD_SERIAL: ""
RUN_CMD_UTILS: ""
RUN_CMD_FCST: ""
RUN_CMD_POST: ""
RUN_CMD_AQM: ""
RUN_CMD_AQMLBC: ""

#
#-----------------------------------------------------------------------
Expand Down
2 changes: 2 additions & 0 deletions ush/machine/cheyenne.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ platform:
RUN_CMD_POST: mpirun -np $nprocs
RUN_CMD_SERIAL: time
RUN_CMD_UTILS: mpirun -np $nprocs
RUN_CMD_AQM: mpirun -np $nprocs
RUN_CMD_AQMLBC: mpirun -np ${NUMTS}
PRE_TASK_CMDS: '{ ulimit -s unlimited; ulimit -a; }'
TEST_EXTRN_MDL_SOURCE_BASEDIR: /glade/p/ral/jntp/UFS_SRW_App/develop/input_model_data
TEST_PREGEN_BASEDIR: /glade/p/ral/jntp/UFS_SRW_App/develop/FV3LAM_pregen
Expand Down
1 change: 1 addition & 0 deletions ush/machine/hera.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ platform:
RUN_CMD_SERIAL: time
RUN_CMD_UTILS: srun --export=ALL
RUN_CMD_AQM: srun -n ${nprocs} --export=ALL
RUN_CMD_AQMLBC: srun --export=ALL -n ${NUMTS}
SCHED_NATIVE_CMD: --export=NONE
PRE_TASK_CMDS: '{ ulimit -s unlimited; ulimit -a; }'
TEST_EXTRN_MDL_SOURCE_BASEDIR: /scratch2/BMC/det/UFS_SRW_App/develop/input_model_data
Expand Down
1 change: 1 addition & 0 deletions ush/machine/orion.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ platform:
RUN_CMD_SERIAL: time
RUN_CMD_UTILS: srun --export=ALL
RUN_CMD_AQM: srun --export=ALL
RUN_CMD_AQMLBC: srun --export=ALL -n ${NUMTS}
SCHED_NATIVE_CMD: --export=NONE
PRE_TASK_CMDS: '{ ulimit -s unlimited; ulimit -a; }'
TEST_EXTRN_MDL_SOURCE_BASEDIR: /work/noaa/fv3-cam/UFS_SRW_App/develop/input_model_data
Expand Down
1 change: 1 addition & 0 deletions ush/machine/wcoss2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ platform:
RUN_CMD_SERIAL: mpiexec
RUN_CMD_UTILS: mpiexec -n ${nprocs}
RUN_CMD_AQM: mpiexec -n ${nprocs} -ppn ${ppn_run_aqm} --cpu-bind core -depth ${omp_num_threads_run_aqm}
RUN_CMD_AQMLBC: mpiexec -n ${NUMTS}
SCHED_NATIVE_CMD: -l place=excl
PRE_TASK_CMDS: '{ ulimit -s unlimited; ulimit -a; }'
TEST_EXTRN_MDL_SOURCE_BASEDIR: /lfs/h2/emc/lam/noscrub/UFS_SRW_App/develop/input_model_data
Expand Down

0 comments on commit 86c3eb0

Please sign in to comment.