Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop]: Document process for changing number of vertical levels #888

Merged
merged 148 commits into from
Sep 6, 2023

Conversation

gspetro-NOAA
Copy link
Collaborator

@gspetro-NOAA gspetro-NOAA commented Aug 15, 2023

DESCRIPTION OF CHANGES:

This PR adds a section to the LAMGrid chapter explaining how to change the number of vertical levels in an SRW App experiment

Type of change

  • This change requires a documentation update

TESTS CONDUCTED:

None required. This is a documentation-only PR. However, I ran through an experiment using the process in the docs to generate ak/bk for 128 levels. I used the resulting VCOORD_FILE to run the community.config.yaml experiment with 128 vertical levels instead of the usual 65. The workflow completed successfully and the results can be viewed on Hera here: /scratch2/NAGAPE/epic/Gillian.Petro/expt_dirs/test_vert2
The human-friendly version of the docs in my fork can be viewed here: https://srw-ug.readthedocs.io/en/text-grid/CustomizingTheWorkflow/LAMGrids.html.

  • hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

PR #880

DOCUMENTATION:

N/A (all docs)

ISSUE:

It seems that PR #813 and the updates in this PR at least partially resolve Issue #397.
I think there was the hope that we could simplify the process for users (e.g., by setting levp / npz and other required variables in config.yaml and generating the ak/bk automatically from that), so it may be best to check with @JeffBeck-NOAA and @gsketefian as to whether to close this issue and open an enhancement issue or just keep this issue open.

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas (N/A)
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes (N/A)
  • Any dependent changes have been merged and published

Copy link
Collaborator

@JeffBeck-NOAA JeffBeck-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your work on this PR, @gspetro-NOAA!

Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gspetro-NOAA - Thank you very much for going into great detail on how to change the number of vertical levels in the SRW App! These changes look good to me! Approving now.

@MichaelLueken MichaelLueken merged commit 661a810 into ufs-community:develop Sep 6, 2023
3 checks passed
@gspetro-NOAA gspetro-NOAA deleted the text/grid branch January 29, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants