-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Input namelist related changes needed for RRFS #744
[develop] Input namelist related changes needed for RRFS #744
Conversation
Machine: hera |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just a few small comments below. Otherwise, it looks good. Thanks for preparing this smaller scope PR!
…nd LBC data retrieval (ufs-community#744)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me. I have one question which I'll include here - GitHub isn't letting me comment on the exact line (not sure why).
Should lines 455 and 457 of exregional_run_fcst.sh use cp_vrfy instead of ln_vrfy? The current version of the script uses cp_vrfy so I was just curious why this was changed.
@BenjaminBlake-NOAA There are now four different input namelists as opposed to the one before. With a symlink it is easier to identify which namelist is used. |
@danielabdi-noaa I agree a symlink makes more sense, thanks for explaining! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielabdi-noaa These changes look good to me! Approving now.
The Jenkins tests failed to make it past the Initialize step on Cheyenne due to an issue with Jenkins. The WE2E coverage tests were manually ran and all passed (it is important to note that the Following the update to the PrgEnv on Gaea last week, the SRW will no longer build on the machine with it's current modulefile. PR #799 will update the The Hera Intel Since the failures are expected, I will now merge this work. |
DESCRIPTION OF CHANGES:
This PR brings back input namelist related changes from RRFS_dev1.
Type of change
TESTS CONDUCTED:
Run community_ensemble_2mems_stoch
DEPENDENCIES:
None
DOCUMENTATION:
ISSUE:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):