Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Add process lightning task #644
[develop] Add process lightning task #644
Changes from 3 commits
a4fd651
3887c34
cb5aa41
2fb34e8
75aa2f2
fa884bb
4cd5472
08786ff
8f16d66
0f781e6
fc0bcad
aa37c87
ce82fd1
b5cf64d
bbb1d3c
29718de
86a4239
76057ea
ff51aea
ffd1471
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have
CDATE
anymore. The date is now passed with NCO-compliantPDY
andcyc
variables. For the timestamp variables below, I think that translates to:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure what the NCO-complaint variables are. But in the develop branch,
CDATE
is used in a number ofufs-srweather-app/scripts/*
and CDATE is defined in thejob_preamble.sh
script asexport CDATE=${PDY}${cyc}
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider
CDATE
to be non-standard, but tolerated in operations (is pretty widely used in the GFS).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay. That's good to know. I switched the code to be:
START_DATE=$(echo "${PDY} ${cyc}")