-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Update ufs-weather-model hash and add WoFS_v0 to suites and tests #492
[develop] Update ufs-weather-model hash and add WoFS_v0 to suites and tests #492
Conversation
Machine: hera |
Machine: jet |
sorc/CMakeLists.txt
Outdated
@@ -35,10 +35,10 @@ endif() | |||
|
|||
# Build UFS weather model | |||
if (BUILD_UFS) | |||
list(APPEND TARGET_LIST ufs-weather-model) | |||
list(APPEND TARGET_LIST UFS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichaelLueken This needs to be removved because it will re-introduce the bug with building without installing the ufs-weather-model.
EXTRN_MDL_FILES_LBCS: | ||
- '{yy}{jjj}{hh}00{fcst_hr:02d}00' | ||
task_run_fcst: | ||
PREDEF_GRID_NAME: SUBCONUS_Ind_3km |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PREDEF_GRID_NAME
should be in workflow:
section after CCPP_PHYS_SUITE:
, and then remove the task_run_fcst
section.
FV3GFS_FILE_FMT_LBCS: grib2 | ||
USE_USER_STAGED_EXTRN_FILES: true | ||
task_run_fcst: | ||
PREDEF_GRID_NAME: SUBCONUS_Ind_3km |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above
1769b7a
to
effa409
Compare
@danielabdi-noaa Thank you very much for the review! I have updated the three files. Please let me know if you see anything else that needs to be addressed. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
With the merging of PR #498 this morning, it is even more imperative that this work be reviewed and merged. The current develop doesn't have the necessary ufs-weather-model hash to use WoFS_v0, nor the necessary changes to files to utilize the new WoFS_v0 SDF. Please take a moment to review this work so that the necessary components to use WoFS_v0 are available in develop. Thanks! |
DESCRIPTION OF CHANGES:
The ufs-weather-model hash was updated in the release/public-v2.1.0 branch to 84b28ec. This hash brings in the WoFS_v0 SDF. This PR will update the ufs-weather-model hash to 84b28ec in the authoritative develop branch and bring in the components for developers to use the WoFS_v0 SDF.
Type of change
TESTS CONDUCTED:
CHECKLIST
@gspetro-NOAA has already updated the documentation in develop, noting that WoFS_v0 is a currently supported CCPP parameter.