Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Add fundamental test suite for Hera using GNU compiler #479

Closed

Conversation

danielabdi-noaa
Copy link
Collaborator

@danielabdi-noaa danielabdi-noaa commented Nov 15, 2022

DESCRIPTION OF CHANGES:

Adds a fundamental test suite for Hera using GNU compiler thanks to #477 . This brings the total number of unique tests in the fundamental suite to 46.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • hera.gnu
    Fundamental test passed.
  • hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

DOCUMENTATION:

None

ISSUE:

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

CONTRIBUTORS (optional):

@danielabdi-noaa danielabdi-noaa changed the title Add fundamental test suite for Hera using GNU compiler [develop] Add fundamental test suite for Hera using GNU compiler Nov 15, 2022
@danielabdi-noaa danielabdi-noaa marked this pull request as ready for review November 15, 2022 16:37
@MichaelLueken
Copy link
Collaborator

@danielabdi-noaa For the Hera GNU fundamental test suite - I'm finding that both grid_RRFS_CONUScompact_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16 and grid_RRFS_AK_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16 are taking over two and half hours two complete.

Should these two tests be included in the fundamental tests? I feel that the fundamental tests should complete within two hours and not be resource intensive. These two tests both take longer to complete and are fairly resource intensive as well.

@danielabdi-noaa
Copy link
Collaborator Author

@MichaelLueken We can definately remove them. I think for me they took 30 mins but i may have used the intel binary

$ python3 create_WE2E_resource_summary.py -e ../../../expt_dirs/
--------------------------------------------------------------------------------------------------------------
--------------------------------------------------------------------------------------------------------------
                                                             Core Hours  |  Run Time (mins)
--------------------------------------------------------------------------------------------------------------
MET_verification                                                 6.77             23.3        
community_ensemble_2mems                                        78.92            223.1        
grid_RRFS_AK_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16          74.77             28.1        
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_g    10.08             28.8        
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_g     7.73             18.2        
grid_RRFS_CONUScompact_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS    29.03             17.5        
--------------------------------------------------------------------------------------------------------------
TOTAL CORE HOURS: 207.30

The community_ensemble_2mems has 2 members and 2 cycles so it is most likely 4x more compute intensive than others. So it doesn't hurt to remove a couple, so I will remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants