Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Port SRW-AQM to Orion and Hercules #1067

Merged
merged 7 commits into from
Apr 8, 2024

Conversation

chan-hoo
Copy link
Collaborator

@chan-hoo chan-hoo commented Apr 4, 2024

DESCRIPTION OF CHANGES:

  • Port SRW-AQM to Orion and Hercules

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • hera.intel
  • orion.intel
  • hercules.intel
  • cheyenne.intel
  • cheyenne.gnu
  • derecho.intel
  • gaea.intel
  • gaeac5.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

ISSUE:

Fixes Issues #1036 and #1037

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chan-hoo -

The AQM WE2E test, aqm_grid_AQM_NA13km_suite_GFS_v16, successfully passed on Orion:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
aqm_grid_AQM_NA13km_suite_GFS_v16_20240404125225                   COMPLETE            6370.25
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE            6370.25

and Hercules:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
aqm_grid_AQM_NA13km_suite_GFS_v16_20240404153142                   COMPLETE            5544.63
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE            5544.63

Approving this PR now.

@chan-hoo
Copy link
Collaborator Author

chan-hoo commented Apr 5, 2024

@MichaelLueken, thanks for approving !!! :)

@chan-hoo
Copy link
Collaborator Author

chan-hoo commented Apr 5, 2024

@RatkoVasic-NOAA, please review this pr :) :)

@RatkoVasic-NOAA
Copy link
Collaborator

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
aqm_grid_AQM_NA13km_suite_GFS_v16_20240405121816                   COMPLETE            6375.65
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE            6375.65

It passed on Orion. On Hercules second run hit the wallclock limit, but everything else was fine. Since Michael already got Hercules run OK, I'm going to approve.

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Apr 5, 2024
@chan-hoo
Copy link
Collaborator Author

chan-hoo commented Apr 8, 2024

@RatkoVasic-NOAA, thank you so much for your approval !!! :)

@MichaelLueken
Copy link
Collaborator

@chan-hoo -

All automated Jenkins tests successfully passed. Moving forward with merging this PR now.

@MichaelLueken MichaelLueken merged commit bf7b490 into ufs-community:develop Apr 8, 2024
4 of 5 checks passed
@chan-hoo chan-hoo deleted the feature/port_orion branch May 30, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SRW-AQM] Need to port SRW-AQM to Hercules [SRW-AQM] Need to port SRW-AQM to Orion
3 participants