Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[production/AQM.v7] Enhancing EE2 compliance for the AQMv7 package #1034

Conversation

JianpingHuang-NOAA
Copy link

DESCRIPTION OF CHANGES:

  1. Removed "nowarn" flags in the ufs-weather-model's makefile and fixed "warning" issues related to CCPP

  2. Deleted unused scripts and utilities

  3. Fixed the hardcoded issues with AQM_UTIL and UFS_UTILS

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • hera.intel
  • orion.intel
  • hercules.intel
  • cheyenne.intel
  • cheyenne.gnu
  • derecho.intel
  • gaea.intel
  • gaeac5.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

@JianpingHuang-NOAA JianpingHuang-NOAA marked this pull request as ready for review February 16, 2024 14:03
@chan-hoo chan-hoo changed the title Enhancing EE2 compliance for the AQMv7 package [production/AQM.v7] Enhancing EE2 compliance for the AQMv7 package Feb 16, 2024
@BrianCurtis-NOAA
Copy link
Collaborator

@chan-hoo it looks like checks are blocking merge here, do you normally bypass that requirement to merge?

@chan-hoo
Copy link
Collaborator

@BrianCurtis-NOAA, uhm... strange. I didn't change anything. I have no idea what happens.

@chan-hoo
Copy link
Collaborator

@BrianCurtis-NOAA, I have not met this error before. Do you know how to fix this?

@BrianCurtis-NOAA
Copy link
Collaborator

Looks like it's mandatory a codeowner reviews, i'll have to add myself to codeowners soon. Can you please @chan-hoo

@BrianCurtis-NOAA BrianCurtis-NOAA merged commit 1308f93 into ufs-community:production/AQM.v7 Feb 16, 2024
1 check failed
@MichaelLueken
Copy link
Collaborator

@BrianCurtis-NOAA and @chan-hoo, you should be safe to bypass branch protections for this failure. A new documentation test has been added. The current documentation subdirectory in develop is docs, rather than the NCO compliant doc. This is why the test is failing (it is looking for contents in docs, rather than doc). This will be addressed in PR #1018.

Please feel free to merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants