Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] adding new e2e tests #792

Conversation

EdwardSnyder-NOAA
Copy link
Collaborator

@EdwardSnyder-NOAA EdwardSnyder-NOAA commented Jun 9, 2022

DESCRIPTION OF CHANGES:

Added 6 new non-compact grids for testing. See the list below. These tests will be included in the upcoming SRW v2 Release. This is the same PR as #786, but it points to the develop branch instead. This PR was created to utilize the Jenkins pipeline.

  • config.grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR.sh
  • config.grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta.sh
  • config.grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR.sh
  • config.grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta.sh
  • config.grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR.sh
  • config.grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta.sh

TESTS CONDUCTED:

The first four tests listed above ran on Orion successfully. The two RRFS_CONUS_3km grids ran successfully on the Parallel Works AWS cluster.

DEPENDENCIES:

No Dependencies.

DOCUMENTATION:

No documentation changes are needed.

ISSUE (optional):

CONTRIBUTORS (optional):

@gsketefian
Copy link
Collaborator

@EdwardSnyder-NOAA Do you mind modifying the PR title to add "[develop]" at the start to indicate that this one is going into the develop branch (I need to start doing that too)? In your other PR (#786), the 3km tests passed. If you can confirm it for this one, I can approve. Thanks.

@EdwardSnyder-NOAA EdwardSnyder-NOAA changed the title adding new e2e tests [develop] adding new e2e tests Jun 10, 2022
@EdwardSnyder-NOAA
Copy link
Collaborator Author

@EdwardSnyder-NOAA Do you mind modifying the PR title to add "[develop]" at the start to indicate that this one is going into the develop branch (I need to start doing that too)? In your other PR (#786), the 3km tests passed. If you can confirm it for this one, I can approve. Thanks.

@gsketefian - Modified the title. All the tests (including the 3km) passed here as well.

@EdwardSnyder-NOAA EdwardSnyder-NOAA merged commit 0884378 into ufs-community:develop Jun 10, 2022
danielabdi-noaa pushed a commit to danielabdi-noaa/regional_workflow that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants