Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crontab newline issue on wcoss_dell_p3 #693

Merged
merged 3 commits into from
Mar 11, 2022
Merged

Fix crontab newline issue on wcoss_dell_p3 #693

merged 3 commits into from
Mar 11, 2022

Conversation

chan-hoo
Copy link
Collaborator

@chan-hoo chan-hoo commented Mar 5, 2022

DESCRIPTION OF CHANGES:

  • Fix the issue that an additional crontab command is not written in a new line on WCOSS Dell.
  • Clean up WCOSS Cray and unnecessary modules for WCOSS Dell.
  • Remove the docs directory from the regional workflow.

TESTS CONDUCTED:

WE2E tests on WCOSS_DELL_P3 and Hera:

  • grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2
  • grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson_mynn_lam3km
  • MET_verification

@@ -214,7 +214,7 @@ Note the following:

* The second argument to the ``compile.sh`` script is ``theia.intel``, not just ``theia``.
Other build targets are:
``cheyenne.gnu, cheyenne.intel, cheyenne.pgi, odin, theia.gnu, theia.intel, theia.pgi`` or ``wcoss_cray``.
``cheyenne.gnu, cheyenne.intel, cheyenne.pgi, odin, theia.gnu, theia.intel`` or ``theia.pgi``.

Copy link
Collaborator

@JeffBeck-NOAA JeffBeck-NOAA Mar 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we got rid of the docs directory in regional_workflow in favor of housing all documentation in ufs-srweather-app? Also, Theia's been retired for a long time.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeffBeck-NOAA, yes.. I remember that we removed this docs directory in my previous PR which was closed without merged. I'll remove the entire docs directory in this PR again.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@chan-hoo chan-hoo merged commit acc89b8 into ufs-community:develop Mar 11, 2022
@chan-hoo chan-hoo deleted the feature/clean_wcoss branch March 14, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants