Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make thompson_mynn_lam3km ccpp suite available #644
Make thompson_mynn_lam3km ccpp suite available #644
Changes from all commits
e599897
816297b
7a99882
bf092f0
19ae300
425a8de
75e0b36
71dda91
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chan-hoo @JeffBeck-NOAA Question: Do these directories need to always be copied or only when using the thompson_mynn_lam3km suite? If the latter, can we wrap them in an if-statement that checks for the suite (i.e. in a new PR, or I can throw it in my current PR)? Just want to reduce the time it takes to generate a new experiment... Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gsketefian, Jili answered this question above: "the MERRA2 aero clim dataset is for the independent aerosol module/scheme and not particular for Thompson scheme."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chan-hoo, is the MERRA2 aero clim dataset only used when running RRFS-CMAQ? If so, then, we may want something like DO_CMAQ="true" in the config.sh file to avoid copying these files unless it's being used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeffBeck-NOAA, No. Since RRFS-CMAQ is coupled with GFS v15, CCPP is not available. MERR2 is used in SRW App (FV3-LAM).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chan-hoo, right, so CMAQ isn't in the picture. So what component of the SRW App uses the MERRA2 dataset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeffBeck-NOAA, if I understand correctly, it is used in thompson_mynn_lam3km now but it can be selected by other CCPP suites. @JiliDong-NOAA, is this correct? Can we turn it on/off in the fv3 namelist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gsketefian @JeffBeck-NOAA , I'll put a flag to turn on/off MERRA2 like 'DO_MERRA' into the regional workflow soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chan-hoo, This SDF won't work with RAP/HRRR-based ICs unless "nstf_name" is 2, 1, 0, 0, 0. Does it need to be 2, 0, 0, 0, 0, or can we change it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that switching the second flag in nstf_name from 0 to 1 means that the NSST data from the surface data file will not be read into the model. If this is not desired/needed, I don't see an issue with changing nstf_name to 2,1,0,0,0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenjaminBlake-NOAA, do you have an answer to Jeff's comment? I'll test [2,1,0,0,0] with both FV3GFS and RAP/HRRR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chan-hoo I think we added comments at the same time :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @BenjaminBlake-NOAA, @chan-hoo, it looks like we need a switch in the workflow to change the values of nstf_name based on the external model data being used for ICs. Since we don't have that at the moment, the easiest solution is to set all suites to 2,1,0,0,0, in which case, I believe FV3 will spin up its own NSST values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @BenjaminBlake-NOAA. I'll test them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeffBeck-NOAA Yes I think that's right about FV3 spinning up its own NSST values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeffBeck-NOAA, @BenjaminBlake-NOAA, both FV3GFS and RAP/HRRR works well with 2,1,0,0,0.