Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new DEBUG variable #639

Merged
merged 8 commits into from
Dec 6, 2021

Conversation

gsketefian
Copy link
Collaborator

@gsketefian gsketefian commented Nov 19, 2021

DESCRIPTION OF CHANGES:

  1. Add a new experiment configuration variable named DEBUG to enable more in-depth debugging output from workflow scripts. Set default value of DEBUG in config_defaults.sh to "FALSE".
  2. In experiment generation scripts, change circumstances under which different messages are printed to screen (e.g. when VERBOSE is "TRUE", when DEBUG is "TRUE", or always).
  3. In experiment generation scripts, for clarity add new informational messages and modify some existing ones.
  4. In various scripts, change "set -x" to "set +x" to reduce output clutter. This can be changed back as necessary (e.g. for debugging).

Note that if DEBUG is set to "TRUE", VERBOSE will get reset to "TRUE" if necessary in order to also print out all the VERBOSE messages.

TESTS CONDUCTED:

Ran the WE2E test grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 as-is as well as with modifications to the default values of VERBOSE and DEBUG, as follows:

  1. grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 as-is, i.e. using default values VERBOSE="TRUE" and DEBUG="FALSE".
  2. grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 modified with VERBOSE="FALSE" (and with default of DEBUG="FALSE").
  3. grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 modified with DEBUG="TRUE" (and with default of VERBOSE="TRUE").
  4. grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 modified with DEBUG="TRUE" and VERBOSE="FALSE" (which should get reset to "TRUE").

All tests were successful. The experiment generation log files (log.generate_FV3LAM_wflow.sh) were compared and differed in the expected ways.

DOCUMENTATION:

Necessary documentation of DEBUG is in config_defaults.sh. Created Issue #640 to also update rst documentation.

…e new experiment variable DEBUG is set to TRUE (as opposed to VERBOSE being set to TRUE).
…nt variable DEBUG is set to TRUE (as opposed to VERBOSE being set to TRUE). Also, for brevity, rename variable file_full_path to file_fp.
…stead of VERBOSE to reduce clutter in output.
@gsketefian gsketefian merged commit c96e0e6 into ufs-community:develop Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants