Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -np warning by RUN_CMD_FCST #633

Merged
merged 3 commits into from
Nov 17, 2021
Merged

Fix -np warning by RUN_CMD_FCST #633

merged 3 commits into from
Nov 17, 2021

Conversation

chan-hoo
Copy link
Collaborator

@chan-hoo chan-hoo commented Nov 15, 2021

DESCRIPTION OF CHANGES:

Since RUN_CMD_FCST causes the warning of "-np: command not found", its expression in 'setup.sh' is changed.

TESTS CONDUCTED:

WE2E tests on WCOSS Dell:

  • grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2
  • grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2
  • grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2

ISSUE:

Fixes issue mentioned in #632

@gsketefian
Copy link
Collaborator

I ran into this as well. I found the easy fix is to put double-quotes around the value of RUN_CMD_FCST in var_defns.sh. To do that, I changed the line in setup.sh that writes RUN_CMD_FCST to var_defns.sh from

RUN_CMD_FCST=$(eval echo ${RUN_CMD_FCST})

to

RUN_CMD_FCST="$(eval echo \'${RUN_CMD_FCST}\')"

The single quotes around ${RUN_CMD_FCST} are so that ${PE_MEMBER01} is not expanded before writing to var_defns.sh. This is something that @mkavulich would like to be implemented in var_defns.sh, i.e. defining variables in terms of already-defined variables in that file. @chan-hoo, can you try just changing this one line (without making any other changes) and seeing if the tests work? Thanks.

@chan-hoo
Copy link
Collaborator Author

@gsketefian , it worked on wcoss, too.

@chan-hoo chan-hoo changed the title Remove default values of RUN_CMD_# to avoid -np warning Fix -np warning by RUN_CMD_FCST Nov 17, 2021
@gsketefian
Copy link
Collaborator

Great, thanks! Approving now.

@chan-hoo chan-hoo merged commit 68694fc into ufs-community:develop Nov 17, 2021
@chan-hoo chan-hoo deleted the feature/warn_np branch November 17, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants