add three parameters to input.nml for NSSL MP #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jili-Dong
requested review from
grantfirl,
ChunxiZhang-NOAA and
dustinswales
as code owners
This was referenced Mar 2, 2023
grantfirl
reviewed
Mar 6, 2023
grantfirl
reviewed
Mar 6, 2023
dustinswales
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
Everything looks good to me.
Thanks @grantfirl @ChunxiZhang-NOAA for the standard_name suggestions.
grantfirl
approved these changes
Mar 7, 2023
ChunxiZhang-NOAA
approved these changes
Mar 7, 2023
37 tasks
Merged
grantfirl
pushed a commit
that referenced
this pull request
Apr 26, 2023
Updated Flake physics and modified related files
|
It is fine with me to add these. I would suggest dropping the "_in" part of the names, though, since the loose convention is to use "nssl_[name of parameter in the scheme]" The alternative way to access these parameters is through a local namelist (nssl_mp_params) that can be read by the init routine. But I don't know if there is a policy/guideline about doing that within CCPP? For a "research" version, it might be good to document this option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support RRFS multiphysics ensemble, three parameters in NSSL MP are being added to input.nml, including rain shape parameter (nssl_alphar), graupel-droplet collection efficiency (nssl_ehw0_in) and hail-droplet collection efficiency (nssl_ehlw0_in)
PR to ccpp/data/GFS_typedefs.F90/meta will be submitted to fv3atm shortly
Related to issue
#44