-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add threading to the filter_topo and orog_gsl codes #948
Add threading to the filter_topo and orog_gsl codes #948
Conversation
driver of filter_topo.F90. Fixes ufs-community#939.
number of threads. The 'orog' and 'filter_topo' programs use threads and should be tested with varying thread counts. Update the hercules driver script to run test twice with 12 and 24 threads. Fixes ufs-community#939.
The
Rerunning the case with one thread showed the same exact differences. So, there is no problem with the threading. I suspect the OMP library on WCOSS2 may use different math libraries which create the difference. In conclusion, the code is working and this PR should be merged. |
@BinLiu-NOAA - can you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the speeding up through OMP threading!
Include threading in both programs. Update the "regional.gsl.gwd" regression test - which runs both programs - to run twice with varying thread counts. Fixes ufs-community#939.
DESCRIPTION OF CHANGES:
filter_topo
andorog_gsl
codes.regional_gsl_gwd
regression test to run with varying thread counts.TESTS CONDUCTED:
If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.
grid_gen
consistency tests locally on all Tier 1 machines. Used 4c0d64c. All tests passed on Orion, Hercules, Jet and Hera. Tests failed on WCOSS2, but this is not a problem. For details, see: Add threading to the filter_topo and orog_gsl codes #948 (comment)Describe any additional tests performed.
Some stand-alone tests of the
filter_topo
program:Some stand-alone tests of the
orog_gsl
program:Some independent tests performed by @BinLiu-NOAA
DEPENDENCIES:
None.
DOCUMENTATION:
N/A
ISSUE:
Fixes #939.