GAEA support, authoritative branches, non-nested global grids #3
Conversation
…hanNOAA/HAFS into WaterInTheWestC5-Nov2023
SamuelTrahanNOAA
changed the title
There was a problem hiding this comment.
@SamuelTrahanNOAA Thanks for inviting me to review this PR. Great work! I was not able to test this on Gaea as I haven't set up a Gaea account yet but I visually went through the changes and it looks good to me. I asked a few questions but they may be general questions and not specific to this PR.
There was a problem hiding this comment.
I assume including "patch.diff" files is a PR requirement?
There was a problem hiding this comment.
Yes. This is an unfortunate workaround for the lack of GAEA C5 support in the components.
I'll do a PR to update the tracker soon.
| @@ -21,6 +21,8 @@ elif [ ${target} == "orion" ]; then | |||
| FIXROOT=/work/noaa/hwrf/noscrub/hafs-fix-files/hafs-${FIXversion}-fix/fix | |||
| elif [ ${target} == "jet" ]; then | |||
| FIXROOT=/lfs4/HFIP/hwrf-data/hafs-fix-files/hafs-${FIXversion}-fix/fix | |||
| elif [[ $target =~ gaea ]]; then | |||
| FIXROOT=/lustre/f2/dev/Samuel.Trahan/hafs/hafs-fix-files/hafs-${FIXversion}-fix/fix | |||
There was a problem hiding this comment.
Is there a plan to move this out of your personal directory?
There was a problem hiding this comment.
Do we have somewhere else to put it?
There was a problem hiding this comment.
We should be able to put it in the role.epic space somewhere.
There was a problem hiding this comment.
Please copy this directory to a communal area:
/lustre/f2/dev/Samuel.Trahan/hafs/hafs-fix-files
and let me know when it is there. I'll update the link_fix.sh.
There was a problem hiding this comment.
I don't want to wait any longer. I'll merge this now. If you provide me a directory later, I'll update the script.
Description of changes
Switch to Authoritative Branches
This switches from HAFS code to the authoritative branches of:
Disable Unused Components
Also, it disables compilation of components that aren't used:
Ports
The HAFS-AR runs on GAEA and Hera except graphics. Pygraf graphics are only installed on Hera.
Uniform and Stretched Global Options
The stretched global and uniform global work. That's a global FV3 with no nest. Access these with:
grid.gtype=uniform or stretch
grid.nest_grids=0
Workarounds
The UPP crashes on GAEA, so we're using the inline post instead.
There's a new CCPP suite FV3_global_nest_v0 which is the FV3_global_nest_v1 with the old gravity wave drag. This is a temporary measure for script testing. The workflow will be updated soon to use the right suite.
The sorc/customizations contains patches that the sorc/build_*.sh scripts apply before compiling. Here are the reasons for them:
Issues addressed (optional)
No issue submitted. Problem is listed in description.
Dependencies (optional)
None.
Contributors (optional)
None.
Tests conducted
Ran an atmospheric river case and verified the output looked like an atmosphere. Did this on GAEA and Hera.
Application-level regression test status
None.