Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

The VGG16_model name for a bottleneck model is dangerous #8

Open
kitsnet opened this issue Jul 27, 2017 · 1 comment
Open

The VGG16_model name for a bottleneck model is dangerous #8

kitsnet opened this issue Jul 27, 2017 · 1 comment
Assignees
Labels

Comments

@kitsnet
Copy link

kitsnet commented Jul 27, 2017

If someone reuses the same naming pattern for their ResNet50 bottleneck model, they are likely to overwrite the existing (non-bottleneck) ResNet50_model, breaking the code of dog_detector().

It's better to replace the name with something more telling (and less confusing), like VGG16_dog_model or VGG16_bottleneck_model.

@cgearhart cgearhart added the bug label Dec 5, 2017
@cgearhart cgearhart self-assigned this Dec 5, 2017
@nblumoe
Copy link

nblumoe commented Jan 1, 2018

Thanks for reporting this (also on the AIND Slack)! I had issues with that naming convention, too: I also used ResNet50 for the final classifier but named my bottleneck model Resnet50_model. Using auto-completion in a few places then mixed up the two different models (existing ResNet50_model and my Resnet50_model) and caused a hard to find bug in using the trained bottleneck model.

This isn't really a bug in the dog-project but indeed the naming convention could be improved to avoid issues we ran into.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants