Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upper-limit or warning for too many courses added at one time #57

Open
snowme34 opened this issue Jan 2, 2019 · 1 comment
Open

Upper-limit or warning for too many courses added at one time #57

snowme34 opened this issue Jan 2, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@snowme34
Copy link
Collaborator

snowme34 commented Jan 2, 2019

Currently it seems that there is no restriction for the number of courses that a user can add.
So a user can add all the courses, which would be one heavy load for our server (it is meaningless but our server still processes it loyally).

It can be assumed that a user may not do so.

But it is very common for some students to add additional courses when planning their schedule even there are time conflicts.

So it can be expected that a lot of users will click the generate button and see an empty result (with warning) on their first few tries.

My suggestion is to include the conflicts as webreg does. Because in real life, students can use things like podcasts.

And to display a small warning about the large number of courses.

@CTrando
Copy link
Collaborator

CTrando commented Jan 31, 2019

I'm not sure about the always adding courses regardless of conflicts because then the generation part loses its value, but having a lot of courses makes for a good error popup, and I will put that on my queue.

@CTrando CTrando added enhancement New feature or request good first issue Good for newcomers labels Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants