Improved image names & README Improvements #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, this is very helpful! |
|
RE: Failed checks
If this can be made work, that would be cool. Since the commits are already pushed, it's practically impossible to rewrite all of their messages. Hopefully that is not too big of an issue. |
|
We can always merge even if the coventional commits fails, that's more to get us used to generating useful changelogs, etc. but we're still figuring stuff out. ( I wouldn't waste time rewriting your history, we have more important things to figure out still and appreciate the help!) |
joshua-stone
pushed a commit
that referenced
this pull request
Feb 8, 2023
* docs: Add documentation improvements from my brief fork * feat: Postfix public image names with -nvidia * docs: Add install commands for both editions. * feat: Add a dispatch trigger to facilitate triggering builds manually and on different branches * docs: Add notice of image name change
joshua-stone
pushed a commit
that referenced
this pull request
Feb 8, 2023
* docs: Add documentation improvements from my brief fork * feat: Postfix public image names with -nvidia * docs: Add install commands for both editions. * feat: Add a dispatch trigger to facilitate triggering builds manually and on different branches * docs: Add notice of image name change
joshua-stone
added a commit
that referenced
this pull request
Feb 8, 2023
* docs: Add documentation improvements from my brief fork * feat: Postfix public image names with -nvidia * docs: Add install commands for both editions. * feat: Add a dispatch trigger to facilitate triggering builds manually and on different branches * docs: Add notice of image name change Co-authored-by: Eino Rauhala <60004820+EinoHR@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Build not properly tested as my repository is not configured correctly. I'm trusting that the on: pull_request: trigger will test building this. I believe the build will succeed with proper configuration, as only the image name (and one line which depended on it) has been changed in build.yml with code I did verify working.