-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved image names & README Improvements #29
Conversation
Thank you, this is very helpful! |
RE: Failed checks
If this can be made work, that would be cool. Since the commits are already pushed, it's practically impossible to rewrite all of their messages. Hopefully that is not too big of an issue. |
We can always merge even if the coventional commits fails, that's more to get us used to generating useful changelogs, etc. but we're still figuring stuff out. ( I wouldn't waste time rewriting your history, we have more important things to figure out still and appreciate the help!) |
* docs: Add documentation improvements from my brief fork * feat: Postfix public image names with -nvidia * docs: Add install commands for both editions. * feat: Add a dispatch trigger to facilitate triggering builds manually and on different branches * docs: Add notice of image name change
* docs: Add documentation improvements from my brief fork * feat: Postfix public image names with -nvidia * docs: Add install commands for both editions. * feat: Add a dispatch trigger to facilitate triggering builds manually and on different branches * docs: Add notice of image name change
* docs: Add documentation improvements from my brief fork * feat: Postfix public image names with -nvidia * docs: Add install commands for both editions. * feat: Add a dispatch trigger to facilitate triggering builds manually and on different branches * docs: Add notice of image name change Co-authored-by: Eino Rauhala <60004820+EinoHR@users.noreply.github.com>
Note: Build not properly tested as my repository is not configured correctly. I'm trusting that the on: pull_request: trigger will test building this. I believe the build will succeed with proper configuration, as only the image name (and one line which depended on it) has been changed in build.yml with code I did verify working.