feat: Make supergfxctl optional based on IMAGE_NAME #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switcheroo can do this same task, so we can move supergfxctl to the image-specific change list. Downstream can pass another value to IMAGE_NAME to prevent any part of supergfxctl from being installed. Could also move this to a separate true/false flag, though that may be less clean.
castrojo
approved these changes
Mar 3, 2024
bsherman
approved these changes
Mar 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switcheroo can do this same task, so we can move supergfxctl to the image-specific change list. Downstream can pass another value to IMAGE_NAME to prevent any part of supergfxctl from being installed.
Could also move this to a separate true/false flag, though that may be less clean.