Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible signed integer overflow in h3NeighborRotations #707

Merged
merged 3 commits into from
Oct 9, 2022
Merged

Fix possible signed integer overflow in h3NeighborRotations #707

merged 3 commits into from
Oct 9, 2022

Conversation

isaacbrodsky
Copy link
Collaborator

h3NeighborRotations adds to the value pointed to by rotations before checking. This isn't part of the public API but we test h3NeighborRotations to a strict standard anyways.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 99.04% when pulling ec4174c on isaacbrodsky:h3neighborrotations-rotations-overflow into de388c6 on uber:master.

@isaacbrodsky isaacbrodsky merged commit 9f25b3f into uber:master Oct 9, 2022
@isaacbrodsky isaacbrodsky deleted the h3neighborrotations-rotations-overflow branch October 9, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrabinowitz nrabinowitz nrabinowitz approved these changes

@dfellis dfellis dfellis approved these changes

@ajfriend ajfriend Awaiting requested review from ajfriend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isaacbrodsky @coveralls @nrabinowitz @dfellis