Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add AnyOf that matches values that satisfy at least one matcher #63

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

favonia
Copy link
Contributor

@favonia favonia commented Aug 15, 2023

Closes #58.

Question: I was checking whether I handled copyright correctly, but CONTRIBUTORS seems very out of date?

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2023

CLA assistant check
All committers have signed the CLA.

@r-hang r-hang self-requested a review September 5, 2023 18:18
@favonia favonia changed the title feat: add AnyOf that matches at least one matcher feat: add AnyOf that matches values that satisfy at least one matcher Sep 16, 2023
Copy link
Contributor

@r-hang r-hang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! thank you for the contribution.

@r-hang
Copy link
Contributor

r-hang commented Sep 18, 2023

@favonia we're looking into the out of date CONTRIBUTORS file issue that you raised. Our team needs to decide on what the new contents should be since we've forked the repo from Google but I can go ahead and merge your changes since we've done that with every other change.

@r-hang r-hang merged commit fcaca4a into uber-go:main Sep 19, 2023
2 checks passed
@favonia favonia deleted the anyof branch September 19, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A matcher that matches at least one of the given matchers
3 participants