Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Cond matcher #60

Merged
merged 4 commits into from
Aug 16, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions gomock/matchers.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,18 @@ func (anyMatcher) String() string {
return "is anything"
}

type condMatcher struct {
fn func(x any) bool
}

func (c condMatcher) Matches(x any) bool {
return c.fn(x)
}

func (condMatcher) String() string {
return "adheres to a custom condition"
}

type eqMatcher struct {
x any
}
Expand Down Expand Up @@ -280,6 +292,15 @@ func All(ms ...Matcher) Matcher { return allMatcher{ms} }
// Any returns a matcher that always matches.
func Any() Matcher { return anyMatcher{} }

// Cond returns a specialized matchers customizable for complex matching behaviour.
// This is particularly useful in case you want to match over a field of a custom struct, or dynamic logic.
damianopetrungaro marked this conversation as resolved.
Show resolved Hide resolved
//
// Example usage:
//
// Cond(func(x any){return x.(int) == 1}).Matches(1) // returns true
// Cond(func(x any){return x.(int) == 2}).Matches(1) // returns false
func Cond(fn func(x any) bool) Matcher { return condMatcher{fn} }

// Eq returns a matcher that matches on equality.
//
// Example usage:
Expand Down
4 changes: 4 additions & 0 deletions gomock/matchers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ import (
)

type A []string
type B struct {
Name string
}

func TestMatchers(t *testing.T) {
type e any
Expand All @@ -50,6 +53,7 @@ func TestMatchers(t *testing.T) {
[]e{[]string{"a", "b"}, A{"a", "b"}},
[]e{[]string{"a"}, A{"b"}},
},
{"test Cond", gomock.Cond(func(x any) bool { return x.(B).Name == "Dam" }), []e{B{Name: "Dam"}}, []e{B{Name: "Dave"}}},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
Expand Down
4 changes: 3 additions & 1 deletion sample/imp4/imp4.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
package imp_four

type Imp4 struct{}
type Imp4 struct {
Field string
}
17 changes: 17 additions & 0 deletions sample/user_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"go.uber.org/mock/gomock"
user "go.uber.org/mock/sample"
"go.uber.org/mock/sample/imp1"
imp_four "go.uber.org/mock/sample/imp4"
)

func TestRemember(t *testing.T) {
Expand Down Expand Up @@ -193,3 +194,19 @@ func TestDoAndReturnSignature(t *testing.T) {
mockIndex.Slice([]int{0}, []byte("meow"))
})
}

func TestExpectCondForeignFour(t *testing.T) {
ctrl := gomock.NewController(t)
defer ctrl.Finish()

mockIndex := NewMockIndex(ctrl)
mockIndex.EXPECT().ForeignFour(gomock.Cond(func(x any) bool {
four, ok := x.(imp_four.Imp4)
if !ok {
return false
}
return four.Field == "Cool"
}))

mockIndex.ForeignFour(imp_four.Imp4{Field: "Cool"})
}