Fix decoration logic for paramSingle #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building paramSingle using decorators, there was a descrepancy when the invoking Scope does not have a decorator for the type but one of its parent Scopes does. This resulted in the parent Scope having to Invoke a function that uses the decorated type for the child to start seeing it too. This fixes paramSingle to search all effective scopes for a decorator and invoke that instead of searching just the scope it was invoked from. Fixes uber-go#316
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
=======================================
Coverage 98.41% 98.42%
=======================================
Files 21 21
Lines 1392 1398 +6
=======================================
+ Hits 1370 1376 +6
Misses 14 14
Partials 8 8
Continue to review full report at Codecov.
|
abhinav
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building paramSingle using decorators, there was a descrepancy when
the invoking Scope does not have a decorator for the type but one of its
parent Scopes does. This resulted in the parent Scope having to Invoke
a function that uses the decorated type for the child to start seeing it
too.
This fixes paramSingle to search all effective scopes for a decorator
and invoke that instead of searching just the scope it was invoked from.
Fixes #316