Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

uBlock doesn't block sfw files that get loaded dynamically #910

Closed
ABPShillNoShillingHere opened this issue Mar 1, 2015 · 8 comments
Closed

Comments

@ABPShillNoShillingHere
Copy link

Hello,

the filter rule
|https://fbstatic-a.akamaihd.net/*.swf
doesn't work on Facebook.
The videos play anyway.

Normally it blocks videos from the Facebook News Feed (in Adblock Edge this rule works).
It's the only reason keeping me from using uBlock.

@gorhill
Copy link
Contributor

gorhill commented Mar 1, 2015

I need a test case to reproduce on my side. uBlock blocks whatever network requests which match the filters, "loaded dynamically" should make no difference.

@ABPShillNoShillingHere
Copy link
Author

Okay, then use that rule in uBlocks custom rules and visit your Facebook feed. The videos will start playing.

I have no other website where I can show you this behaviour though.

@gorhill
Copy link
Contributor

gorhill commented Mar 1, 2015

What version of uBlock are you using? This bug was fixed yesterday: #903. It's fixed in 0.9.8.1.

@ABPShillNoShillingHere
Copy link
Author

I downloaded the latest version 0.8.9.1 from here (GitHub).

@gorhill
Copy link
Contributor

gorhill commented Mar 1, 2015

I don't have a Facebook account, that's why I need a web page. Anyways, I found one: https://www.facebook.com/video.php?v=781508688605093&set=vb.514608705295094&type=2&theater.

I tried your rule, |https://fbstatic-a.akamaihd.net/*.swf, and the video got blocked:

d

Using 0.8.9.1.

@gorhill
Copy link
Contributor

gorhill commented Mar 1, 2015

Actually, I realize if uBlock created a selfie while you have the bug, the selfie won't be invalidated with the new version, meaning the buggy filter is still in the selfie. My bad. Workaround is to toggle on/off the "Parse and enforce cosmetic filters" option, click "Apply changes", then toggle back to its previous state, or just change the selection of lists somehow, and revert, in order to force an invalidation of the selfie.

@ABPShillNoShillingHere
Copy link
Author

Nice, you respond very fast. 👍

I just tried it again, not updated uBlock (as I already had latest) nor anything else and it really works now.

Thanks, now also I can see if uBlock really is better than the others or not. 👍

@gorhill
Copy link
Contributor

gorhill commented Mar 1, 2015

Nice, you respond very fast

Well, if I happen to be in front of the computer, I will usually.

@gorhill gorhill closed this as completed Mar 1, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants