fix: add locale parameter for isAlpha and isAlphanumeric validators #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlapo
suggested changes
Aug 20, 2019
src/validation/Validator.ts
Outdated
| @@ -495,16 +495,16 @@ export class Validator { | |||
| * Checks if the string contains only letters (a-zA-Z). | |||
| * If given value is not a string, then it returns false. | |||
| */ | |||
| isAlpha(value: string): boolean { | |||
| return typeof value === "string" && this.validatorJs.isAlpha(value); | |||
| isAlpha(value: string, locale: ValidatorJS.AlphaLocale = "en-US"): boolean { | |||
There was a problem hiding this comment.
Please leave locale parameter without default value. validator.js lib will use "en-US" by default. Same for isAlphanumeric.
vlapo
changed the title
|
will do |
|
I have also fixed the number options on the isnumeric string on the same pr |
|
@vlapo I have addressed your changes. |
vlapo
approved these changes
Sep 24, 2019
|
Thank you for contribution. |
|
Anytime |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the feature to add locale to both isAlpha and isAlphanumeric with default as en-US