Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): backport no-unsafe-function type, no-wrapper-object-types from v8 to v7 #9507

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Also adds the docs touchup requested by #9503 while I'm in the area.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jul 6, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit cb1ae31
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/669945fd283b390008e3c63e
😎 Deploy Preview https://deploy-preview-9507--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@kirkwaiblinger
Copy link
Member

kirkwaiblinger commented Jul 12, 2024

FYI @JoshuaKGoldberg - I just merged #9363 to v8, so you'll want to update this PR with those changes

Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JoshuaKGoldberg and others added 2 commits July 13, 2024 14:11
Co-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com>
bradzacher
bradzacher previously approved these changes Jul 14, 2024
@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 14, 2024
kirkwaiblinger
kirkwaiblinger previously approved these changes Jul 14, 2024
kirkwaiblinger
kirkwaiblinger previously approved these changes Jul 17, 2024
@JoshuaKGoldberg
Copy link
Member Author

Aha! The check from #9243 is saving us on this one.

Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like might need to rerun some test snapshots? Otherwise LGTM

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (8258dae) to head (cb1ae31).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9507      +/-   ##
==========================================
+ Coverage   88.38%   88.40%   +0.01%     
==========================================
  Files         419      422       +3     
  Lines       14620    14652      +32     
  Branches     4279     4287       +8     
==========================================
+ Hits        12922    12953      +31     
  Misses       1374     1374              
- Partials      324      325       +1     
Flag Coverage Δ
unittest 88.40% <96.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...eslint-plugin/src/rules/no-unsafe-function-type.ts 100.00% <100.00%> (ø)
...eslint-plugin/src/rules/no-wrapper-object-types.ts 100.00% <100.00%> (ø)
packages/eslint-plugin/src/util/scopeUtils.ts 75.00% <75.00%> (ø)

Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@JoshuaKGoldberg JoshuaKGoldberg merged commit dd965a4 into typescript-eslint:main Jul 18, 2024
61 of 63 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the more-ban-types-rules-v7 branch July 18, 2024 17:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
3 participants