Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stubtest] Fix forms media property definitions #1629

Merged
merged 1 commit into from
Jul 16, 2023
Merged

[stubtest] Fix forms media property definitions #1629

merged 1 commit into from
Jul 16, 2023

Conversation

UnknownPlatypus
Copy link
Contributor

This fix 106 stubtest errors about the media form property.
I also did some related misc cleanups.

Cheers

@UnknownPlatypus
Fix forms media property definitions
3b1c85b 
Fixes 106 stubtest errors
sobolevn
sobolevn approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@sobolevn sobolevn merged commit cef666d into typeddjango:master Jul 16, 2023
28 checks passed
@UnknownPlatypus UnknownPlatypus deleted the stubtest/forms_media branch July 17, 2023 08:11
adamchainz
adamchainz reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@adamchainz adamchainz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, very efficient cutting down of the todo list :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamchainz adamchainz adamchainz left review comments

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UnknownPlatypus @adamchainz @sobolevn