Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxresdefault and sddefault are not guaranteed to exist #45

Open
jvanasco opened this issue Jul 20, 2015 · 1 comment
Open

maxresdefault and sddefault are not guaranteed to exist #45

jvanasco opened this issue Jul 20, 2015 · 1 comment

Comments

@jvanasco
Copy link

This is a regression introduced by this ticket: #12

I haven't been able to find any current YouTube docs, but "common knowledge" (as noted in this stack overflow post http://stackoverflow.com/a/20542029/442650) is that maxresdefault/sddefault only exist for videos that have been uploaded in high definition.

The way the plugin is currently coded, it will try to embed these non-existent images. the result is that

Here's an example with an older movie trailer that was not uploaded in HD:

The only way to tell if maxresdefault or sddefault exists is to query the API. This library should either max out on the hqdefault image size (never use maxresdefault or sddefault) or query the API to decide if they should be used. Unfortunately the current behavior of the library makes some content look great, and the rest look absolutely terrible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants