remove script,noscript and style tags from suggestions #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests takes the compiled html for the suggestions and removes all scripts, noscripts and style elements. This is useful in cases where the source data is bad (contains javascript injection). Currently with this library, if it were to receive a suggestion with a script element, it would inject that into the dom and the alert would be executed.
Caveats: Would no longer allow for purposeful use of those tags in suggestions. Not sure why someone would want to do that though.
Please let me know your thoughts. Maybe this should be configurable instead? Or maybe there is a better place to make this change?