-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(gateway,model)!: rename GUILD_EMOJIS
intent and make corresponding changes
#1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esponding changes to various types
HTGAzureX1212
changed the title
chore(model): rename
chore(model, standby): rename Feb 8, 2022
GUILD_EMOJIS
intent and make corresponding changesGUILD_EMOJIS
intent and make corresponding changes
HTGAzureX1212
changed the title
chore(model, standby): rename
chore(cache, model, standby): rename Feb 8, 2022
GUILD_EMOJIS
intent and make corresponding changesGUILD_EMOJIS
intent and make corresponding changes
HTGAzureX1212
changed the title
chore(cache, model, standby): rename
chore(cache,gateway,model,standby): rename Feb 8, 2022
GUILD_EMOJIS
intent and make corresponding changesGUILD_EMOJIS
intent and make corresponding changes
7596ff
reviewed
Feb 8, 2022
7596ff
approved these changes
Feb 9, 2022
Looks good, just need you to make these changes before we can merge it |
Co-authored-by: Cassandra McCarthy <cassie@7596ff.com>
Co-authored-by: Cassandra McCarthy <cassie@7596ff.com>
Co-authored-by: Cassandra McCarthy <cassie@7596ff.com>
Done. |
itohatweb
approved these changes
Feb 10, 2022
7596ff
changed the title
chore(cache,gateway,model,standby): rename
feat(gateway,model)!: rename Feb 10, 2022
GUILD_EMOJIS
intent and make corresponding changesGUILD_EMOJIS
intent and make corresponding changes
github-actions
bot
added
m-breaking change
Breaks the public API.
t-feature
Addition of a new feature
labels
Feb 10, 2022
7596ff
changed the title
feat(gateway,model)!: rename
refactor(gateway,model)!: rename Feb 10, 2022
GUILD_EMOJIS
intent and make corresponding changesGUILD_EMOJIS
intent and make corresponding changes
7596ff
added a commit
that referenced
this pull request
Mar 10, 2022
Additions Add `{ClusterBuilder, ShardBuilder}::ratelimit_payloads`, which if set to false, enables the sending of un-ratelimited payloads ([#1501] - [@Gelbpunkt]). This is `true` by default. Additionally, `Information::{ratelimit_refill, ratelimit_requests}` are now optional. Add `EventTypeFlags::GUILD_STICKERS_UPDATE`, and rename/update `GUILD_EMOJIS_AND_STICKERS` ([#1520] - [@HTG-YT]). Changes Remove the `compression` feature, which was not used in any code ([#1497] - [@vilgotf]). Update to Discord API version 10 ([#1540] - [@zeylahellyer]). [#1497]: #1497 [#1501]: #1501 [#1520]: #1520 [#1540]: #1540 [@Gelbpunkt]: https://github.com/Gelbpunkt [@HTG-YT]: https://github.com/HTG-YT [@vilgotf]: https://github.com/vilgotf [@zeylahellyer]: https://github.com/zeylahellyer
7596ff
added a commit
that referenced
this pull request
Mar 10, 2022
Channels The `Channel` type has been unified into a struct ([#1449] - [@zeylahellyer], [@itohatweb]). All possible fields of every channel variant and thread variant are now present on this type. This change was prompted by Discord's own storage of channels, and that variants do not necessarily have guaranteed fields. See the PR description for more details. New `http` module Add a new module, `http` ([#1508], [#1521] - [@7596ff]). This module contains types that are only sent to Discord. `AttachmentFile` has been moved from `twilight-http` and renamed to `model::http::attachment::Attachment`. `InteractionResponse` has been moved to `model::http::interaction::InteractionResponse`. `CallbackData` has been renamed to `InteractionResponseData`. `PermissionOverwrite` now has a separate type in `model::http`; it differs from a received `PermissionOverwrite` in that its `allow` and `deny` fields are optional. Additions Add support for modals ([#1300] - [@itohatweb], [@7596ff]): - Sending - add a new component, `TextInput` - move `Component` de/serialization to the enum itself, and remove all de/serialization from its variants - Receiving - add `Interaction::Modal`, `InteractionType::ModalSubmit` - add `ModalSubmitInteraction`, `ModalInteractionData`, `ModalInteractionDataActionRow`, `ModalInteractionDataComponent` Add `GuildStickersUpdate` to the `Event` enum ([#1520] - [@HTG-YT]). Changes `Event` variants have been boxed or unboxed based on a new threshold, making the size of the enum more consistent ([#1436] - [@vilgotf]). Rename `Intents::GUILD_EMOJIS` to `GUILD_EMOJIS_AND_STICKERS` ([#1520] - [@HTG-YT]). `PermissionOverwrite` has been refactored to more closely represent Discord's model ([#1521] - [@7596ff]). Its ID is stored with a generic marker, and can be casted to a member or role ID as needed. Update to Discord API version 10 ([#1540] - [@zeylahellyer]). This involves two changes: - remove `CurrentApplicationInfo`'s `summary` field - add `Intents::MESSAGE_CONTENT` [#1300]: #1300 [#1436]: #1436 [#1449]: #1449 [#1508]: #1508 [#1520]: #1520 [#1521]: #1521 [#1540]: #1540 [@7596ff]: https://github.com/7596ff [@HTG-YT]: https://github.com/HTG-YT [@itohatweb]: https://github.com/itohatweb [@vilgotf]: https://github.com/vilgotf [@zeylahellyer]: https://github.com/zeylahellyer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c-cache
Affects the cache crate
c-gateway
Affects the gateway crate
c-model
Affects the model crate
c-standby
Affects the standby crate
m-breaking change
Breaks the public API.
t-feature
Addition of a new feature
t-refactor
Refactors APIs or code.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.