Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gateway,model)!: rename GUILD_EMOJIS intent and make corresponding changes #1520

Merged
merged 12 commits into from
Feb 10, 2022

Conversation

HTGAzureX1212
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the c-model Affects the model crate label Feb 8, 2022
@HTGAzureX1212 HTGAzureX1212 changed the title chore(model): rename GUILD_EMOJIS intent and make corresponding changes chore(model, standby): rename GUILD_EMOJIS intent and make corresponding changes Feb 8, 2022
@github-actions github-actions bot added the c-standby Affects the standby crate label Feb 8, 2022
@HTGAzureX1212 HTGAzureX1212 changed the title chore(model, standby): rename GUILD_EMOJIS intent and make corresponding changes chore(cache, model, standby): rename GUILD_EMOJIS intent and make corresponding changes Feb 8, 2022
@github-actions github-actions bot added the c-cache Affects the cache crate label Feb 8, 2022
@HTGAzureX1212 HTGAzureX1212 changed the title chore(cache, model, standby): rename GUILD_EMOJIS intent and make corresponding changes chore(cache,gateway,model,standby): rename GUILD_EMOJIS intent and make corresponding changes Feb 8, 2022
@github-actions github-actions bot added the c-gateway Affects the gateway crate label Feb 8, 2022
cache/in-memory/src/lib.rs Outdated Show resolved Hide resolved
cache/in-memory/src/lib.rs Outdated Show resolved Hide resolved
cache/in-memory/src/lib.rs Outdated Show resolved Hide resolved
@7596ff
Copy link
Contributor

7596ff commented Feb 9, 2022

Looks good, just need you to make these changes before we can merge it

HTGAzureX1212 and others added 3 commits February 10, 2022 08:30
Co-authored-by: Cassandra McCarthy <cassie@7596ff.com>
Co-authored-by: Cassandra McCarthy <cassie@7596ff.com>
Co-authored-by: Cassandra McCarthy <cassie@7596ff.com>
@HTGAzureX1212
Copy link
Contributor Author

Done.

@7596ff 7596ff changed the title chore(cache,gateway,model,standby): rename GUILD_EMOJIS intent and make corresponding changes feat(gateway,model)!: rename GUILD_EMOJIS intent and make corresponding changes Feb 10, 2022
@github-actions github-actions bot added m-breaking change Breaks the public API. t-feature Addition of a new feature labels Feb 10, 2022
@7596ff 7596ff changed the title feat(gateway,model)!: rename GUILD_EMOJIS intent and make corresponding changes refactor(gateway,model)!: rename GUILD_EMOJIS intent and make corresponding changes Feb 10, 2022
@github-actions github-actions bot added the t-refactor Refactors APIs or code. label Feb 10, 2022
@7596ff 7596ff merged commit d255499 into twilight-rs:next Feb 10, 2022
@HTGAzureX1212 HTGAzureX1212 deleted the rename-intent branch February 11, 2022 00:52
7596ff added a commit that referenced this pull request Mar 10, 2022
Additions

Add `{ClusterBuilder, ShardBuilder}::ratelimit_payloads`, which if set
to false, enables the sending of un-ratelimited payloads ([#1501] -
[@Gelbpunkt]). This is `true` by default. Additionally,
`Information::{ratelimit_refill, ratelimit_requests}` are now optional.

Add `EventTypeFlags::GUILD_STICKERS_UPDATE`, and rename/update
`GUILD_EMOJIS_AND_STICKERS` ([#1520] - [@HTG-YT]).

Changes

Remove the `compression` feature, which was not used in any code
([#1497] - [@vilgotf]).

Update to Discord API version 10 ([#1540] - [@zeylahellyer]).

[#1497]: #1497
[#1501]: #1501
[#1520]: #1520
[#1540]: #1540

[@Gelbpunkt]: https://github.com/Gelbpunkt
[@HTG-YT]: https://github.com/HTG-YT
[@vilgotf]: https://github.com/vilgotf
[@zeylahellyer]: https://github.com/zeylahellyer
7596ff added a commit that referenced this pull request Mar 10, 2022
Channels

The `Channel` type has been unified into a struct ([#1449] -
[@zeylahellyer], [@itohatweb]). All possible fields of every channel
variant and thread variant are now present on this type. This change was
prompted by Discord's own storage of channels, and that variants do not
necessarily have guaranteed fields. See the PR description for more
details.

New `http` module

Add a new module, `http` ([#1508], [#1521] - [@7596ff]). This module
contains types that are only sent to Discord.

`AttachmentFile` has been moved from `twilight-http` and renamed to
`model::http::attachment::Attachment`.

`InteractionResponse` has been moved to
`model::http::interaction::InteractionResponse`. `CallbackData` has been
renamed to `InteractionResponseData`.

`PermissionOverwrite` now has a separate type in `model::http`; it
differs from a received `PermissionOverwrite` in that its `allow` and
`deny` fields are optional.

Additions

Add support for modals ([#1300] - [@itohatweb], [@7596ff]):
- Sending
  - add a new component, `TextInput`
  - move `Component` de/serialization to the enum itself, and remove all
    de/serialization from its variants
- Receiving
  - add `Interaction::Modal`, `InteractionType::ModalSubmit`
  - add `ModalSubmitInteraction`, `ModalInteractionData`,
    `ModalInteractionDataActionRow`, `ModalInteractionDataComponent`

Add `GuildStickersUpdate` to the `Event` enum ([#1520] - [@HTG-YT]).

Changes

`Event` variants have been boxed or unboxed based on a new threshold,
making the size of the enum more consistent ([#1436] - [@vilgotf]).

Rename `Intents::GUILD_EMOJIS` to `GUILD_EMOJIS_AND_STICKERS` ([#1520] -
[@HTG-YT]).

`PermissionOverwrite` has been refactored to more closely represent
Discord's model ([#1521] - [@7596ff]). Its ID is stored with a generic
marker, and can be casted to a member or role ID as needed.

Update to Discord API version 10 ([#1540] - [@zeylahellyer]). This
involves two changes:
- remove `CurrentApplicationInfo`'s `summary` field
- add `Intents::MESSAGE_CONTENT`

[#1300]: #1300
[#1436]: #1436
[#1449]: #1449
[#1508]: #1508
[#1520]: #1520
[#1521]: #1521
[#1540]: #1540

[@7596ff]: https://github.com/7596ff
[@HTG-YT]: https://github.com/HTG-YT
[@itohatweb]: https://github.com/itohatweb
[@vilgotf]: https://github.com/vilgotf
[@zeylahellyer]: https://github.com/zeylahellyer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-cache Affects the cache crate c-gateway Affects the gateway crate c-model Affects the model crate c-standby Affects the standby crate m-breaking change Breaks the public API. t-feature Addition of a new feature t-refactor Refactors APIs or code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants