Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropright/dropleft is broken on navbar or with static position #25304

Closed
ysds opened this issue Jan 15, 2018 · 4 comments
Closed

Dropright/dropleft is broken on navbar or with static position #25304

ysds opened this issue Jan 15, 2018 · 4 comments

Comments

@ysds
Copy link
Member

ysds commented Jan 15, 2018

I wondered why position: relative is not given to dropright and dropleft, so examined any influence.

Related code:

.dropup,
.dropdown {
position: relative;
}

Then, I found a position of dropright or dropleft is not as expected when using it on a navbar. Demo Please see on a large screen.

Also, a dropright/dropleft outside navbar works well since it is positioned by popper, but if disable poper (#24092) it will break position.

@XhmikosR
Copy link
Member

/CC @mdo @Johann-S

@Johann-S
Copy link
Member

Yep we made the choice a few release before to not enable Popper.js in our navbar component but with .dropleft or .dropright I'm not sure if we'll have the choice to not use Popper.js

@mdo
Copy link
Member

mdo commented Jan 15, 2018

Perhaps we limit left/right to everything but navbars? Or do we try to do some basic positioning for them inside navbars?

@ysds
Copy link
Member Author

ysds commented Mar 15, 2018

Resolved in #25400

@ysds ysds closed this as completed Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants